Fold InternalSearchHits and friends into their interfaces #23042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a bunch of interfaces that have only a single implementation for 6 years now. These interfaces are pretty useless from a SW development perspective and only add unnecessary abstractions. They also require lots of casting in many places where we expect that there is only one concrete implementation. This change removes the interfaces, makes all of the classes final and removes the duplicate `foo` `getFoo` accessors in favor of `getFoo` from these classes.
s1monw
added
:Core/Infra/Transport API
jpountz
approved these changes
Feb 8, 2017
| for (int i = 0; i < reducedTopDocs.scoreDocs.length; i++) { | ||
| ScoreDoc scoreDoc = reducedTopDocs.scoreDocs[i]; | ||
| int position; | ||
| do { | ||
| position = tracker[scoreDoc.shardIndex]++; | ||
| } while (shardDocs[scoreDoc.shardIndex].scoreDocs[position] != scoreDoc); | ||
| hits[i] = (InternalSearchHit) shardHits[scoreDoc.shardIndex].getAt(position); | ||
| hits[i] = (SearchHit) shardHits[scoreDoc.shardIndex].getAt(position); |
| @@ -56,7 +55,7 @@ public void accept(SearchRequest searchRequest, SearchResponse searchResponse) { | |||
| return ; | |||
| } | |||
| for (SearchHit hit : searchResponse.getHits()) { | |||
| InternalSearchHit internalHit = (InternalSearchHit) hit; | |||
| SearchHit internalHit = (SearchHit) hit; | |||
| @@ -133,14 +133,14 @@ private Object randomOfType(SortField.Type type) { | |||
|
|
|||
| @Override | |||
| protected void assertReduced(InternalTopHits reduced, List<InternalTopHits> inputs) { | |||
| InternalSearchHits actualHits = (InternalSearchHits) reduced.getHits(); | |||
| List<Tuple<ScoreDoc, InternalSearchHit>> allHits = new ArrayList<>(); | |||
| SearchHits actualHits = (SearchHits) reduced.getHits(); | |||
| InternalSearchHits internalHits = (InternalSearchHits) inputs.get(input).getHits(); | ||
| totalHits += internalHits.totalHits(); | ||
| maxScore = max(maxScore, internalHits.maxScore()); | ||
| SearchHits internalHits = (SearchHits) inputs.get(input).getHits(); |
s1monw
added a commit
that referenced
this pull request
Feb 14, 2017
We have a bunch of interfaces that have only a single implementation for 6 years now. These interfaces are pretty useless from a SW development perspective and only add unnecessary abstractions. They also require lots of casting in many places where we expect that there is only one concrete implementation. This change removes the interfaces, makes all of the classes final and removes the duplicate `foo` `getFoo` accessors in favor of `getFoo` from these classes. This is a backport of ecb01c1 that deprecates all methods that are removed in 6.0
SGM3
added a commit
to SGM3/liferay-portal
that referenced
this pull request
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of interfaces that have only a single implementation
for 6 years now. These interfaces are pretty useless from a SW development
perspective and only add unnecessary abstractions. They also require
lots of casting in many places where we expect that there is only one
concrete implementation. This change removes the interfaces, makes
all of the classes final and removes the duplicate
foogetFooaccessorsin favor of
getFoofrom these classes.