New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for ipv6 on legacy ip fields #23136

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
3 participants
@rjernst
Member

rjernst commented Feb 12, 2017

The legacy ip fields, which still use the term dictionary, support only
ipv4 addresses. This change improves the error message when an ipv6
address is parsed for a legacy field, to indicate reindexing is
necessary to use ipv6 addresses.

relates #23126

Improve error message for ipv6 on legacy ip fields
The legacy ip fields, which still use the term dictionary, support only
ipv4 addresses. This change improves the error message when an ipv6
address is parsed for a legacy field, to indicate reindexing is
necessary to use ipv6 addresses.

relates #23126
@jasontedor

LGTM.

@jasontedor

This comment has been minimized.

Member

jasontedor commented Feb 13, 2017

I think this should have a v5.3.1 label, hard to say at this point but we can always relabel to v5.3.0 if it does make it in.

@jasontedor

This comment has been minimized.

Member

jasontedor commented Feb 13, 2017

After discussing with @clintongormley, I think it's likely that this will make it into v5.3.0 so we can just keep that label.

@rjernst rjernst merged commit c13fbdf into elastic:5.x Feb 13, 2017

1 check passed

CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:ip_legacy_message branch Feb 13, 2017

rjernst added a commit that referenced this pull request Feb 13, 2017

Improve error message for ipv6 on legacy ip fields (#23136)
The legacy ip fields, which still use the term dictionary, support only
ipv4 addresses. This change improves the error message when an ipv6
address is parsed for a legacy field, to indicate reindexing is
necessary to use ipv6 addresses.

relates #23126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment