New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setting deprecation message #23156

Merged
merged 1 commit into from Feb 15, 2017

Conversation

Projects
None yet
4 participants
@rjernst
Member

rjernst commented Feb 13, 2017

This change modifies the deprecation log message emitted when a setting
is found which is deprecated. The new message indicates docs for the
deprecated settings can be found in the breaking changes docs for the
next major version.

closes #22849

Improve setting deprecation message
This change modifies the deprecation log message emitted when a setting
is found which is deprecated. The new message indicates docs for the
deprecated settings can be found in the breaking changes docs for the
next major version.

closes #22849
@dadoonet

I'm wondering if we can generate automatically the link to the next major version doc. May be it's too much though.

@s1monw

This comment has been minimized.

Contributor

s1monw commented Feb 14, 2017

LGTM2

@rjernst rjernst merged commit 048c87d into elastic:master Feb 15, 2017

1 of 2 checks passed

elasticsearch-ci Build finished.
Details
CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:deprecation_message branch Feb 15, 2017

rjernst added a commit that referenced this pull request Feb 15, 2017

Improve setting deprecation message (#23156)
This change modifies the deprecation log message emitted when a setting
is found which is deprecated. The new message indicates docs for the
deprecated settings can be found in the breaking changes docs for the
next major version.

closes #22849

rjernst added a commit that referenced this pull request Feb 15, 2017

Improve setting deprecation message (#23156)
This change modifies the deprecation log message emitted when a setting
is found which is deprecated. The new message indicates docs for the
deprecated settings can be found in the breaking changes docs for the
next major version.

closes #22849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment