Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get mappings HEAD requests #23192

Merged
merged 7 commits into from Jun 11, 2017

Conversation

Projects
None yet
6 participants
@jasontedor
Copy link
Member

commented Feb 15, 2017

Get mappings HEAD requests incorrectly return a content-length header of 0. This commit addresses this by removing the special handling for get mappings HEAD requests, and just relying on the general mechanism that exists for handling HEAD requests in the REST layer.

Relates #21125

Fix get mappings HEAD requests
Get mappings HEAD requests incorrectly return a content-length header of
0. This commit addresses this by removing the special handling for get
mappings HEAD requests, and just relying on the general mechanism that
exists for handling HEAD requests in the REST layer.
@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2017

This is the last one @nik9000!

@nik9000

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2017

This is the last one @nik9000!

❤️

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 23, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@javanna

This comment has been minimized.

Copy link
Member

commented Apr 14, 2017

@jasontedor any reason why this didn't make it in yet?

Merge branch 'master' into fix-get-mapping-head
* master: (1210 commits)
  Add support for clear scroll to high level REST client (#25038)
  Tiny correction in inner-hits.asciidoc (#25066)
  Added release notes for 6.0.0-alpha2
  Expand index expressions against indices only when managing aliases (#23997)
  Collapse inner hits rest test should not skip 5.x
  Settings: Fix secure settings by prefix (#25064)
  add `exclude_keys` option to KeyValueProcessor (#24876)
  Test: update missing body tests to run against versions >= 5.5.0
  Track EWMA[1] of task execution time in search threadpool executor
  Removes an invalid assert in resizing big arrays which does not always hold (resizing can result in a smaller size than the current size, while the assert attempted to verify the new size is always greater than the current).
  Fixed NPEs caused by requests without content. (#23497)
  Plugins can register pre-configured char filters (#25000)
  Build: Allow preserving shared dir (#24962)
  Tests: Make secure settings available from settings builder for tests (#25037)
  [TEST] Skip wildcard expansion test due to breaking change
  Test that gradle and Java version types match (#24943)
  Include duplicate jar when jarhell check fails
  Change ScriptContexts to use needs instead of uses$. (#25036)
  Change `has_child`, `has_parent` queries and `childen` aggregation to work with the new join field type and at the same time maintaining support for the `_parent` meta field type.
  Remove comma-separated feature parsing for GetIndicesAction
  ...

@jasontedor jasontedor added v5.5.0 and removed v5.4.2 labels Jun 6, 2017

jasontedor added some commits Jun 10, 2017

Merge branch 'master' into fix-get-mapping-head
* master: (80 commits)
  Test: remove faling test that relies on merge order
  Log checkout so SHA is known
  Add link to community Rust Client (#22897)
  "shard started" should show index and shard ID (#25157)
  await fix testWithRandomException
  Change BWC versions on create index response
  Return the index name on a create index response
  Remove incorrect bwc branch logic from master
  Correctly format arrays in output
  [Test] Extending parsing checks for SearchResponse (#25148)
  Scripting: Change keys for inline/stored scripts to source/id (#25127)
  [Test] Add test for custom requests in High Level Rest Client (#25106)
  nested: In case of a single type the _id field should be added to the nested document instead of _uid field.
  `type` and `id` are lost upon serialization of `Translog.Delete`. (#24586)
  fix highlighting docs
  Fix NPE in token_count datatype with null value (#25046)
  Remove the postings highlighter and make unified the default highlighter choice (#25028)
  [Test] Adding test for parsing SearchShardFailure leniently (#25144)
  Fix typo in shards.asciidoc (#25143)
  List Hibernate Search (#25145)
  ...
Merge branch 'master' into fix-get-mapping-head
* master:
  Fix handling of exceptions thrown on HEAD requests
  Fix comment formatting in EvilLoggerTests
  Remove unneeded weak reference from prefix logger

@jasontedor jasontedor force-pushed the jasontedor:fix-get-mapping-head branch to ae13341 Jun 11, 2017

@jasontedor jasontedor merged commit dcf57f2 into elastic:master Jun 11, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

jasontedor added a commit that referenced this pull request Jun 11, 2017

Fix get mappings HEAD requests
Get mappings HEAD requests incorrectly return a content-length header of
0. This commit addresses this by removing the special handling for get
mappings HEAD requests, and just relying on the general mechanism that
exists for handling HEAD requests in the REST layer.

Relates #23192

jasontedor added a commit that referenced this pull request Jun 11, 2017

Fix get mappings HEAD requests
Get mappings HEAD requests incorrectly return a content-length header of
0. This commit addresses this by removing the special handling for get
mappings HEAD requests, and just relying on the general mechanism that
exists for handling HEAD requests in the REST layer.

Relates #23192

jasontedor added a commit that referenced this pull request Jun 11, 2017

Change BWC versions on get mapping 404s
This commit changes the BWC versions on the get mapping 404s now that
this API returning 404s when a type is missing is supported since 5.5.0.

Relates #23192

jasontedor added a commit that referenced this pull request Jun 11, 2017

Change BWC versions on get mapping 404s
This commit changes the BWC versions on the get mapping 404s now that
this API returning 404s when a type is missing is supported since 5.5.0.

Relates #23192

@jasontedor jasontedor deleted the jasontedor:fix-get-mapping-head branch Jun 11, 2017

@colings86 colings86 added v6.0.0-beta1 and removed v6.0.0 labels Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.