Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix control group pattern #23219

Merged
merged 2 commits into from Feb 16, 2017

Conversation

@jasontedor
Copy link
Member

commented Feb 16, 2017

The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:

  1. a hierarchy ID number
  2. a comma-separated list of hierarchies
  3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.

Closes #23218

The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:
 1. a hierarchy ID number
 2. a comma-separated list of hierarchies
 3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.
Copy link
Member

left a comment

LGTM

@jasontedor jasontedor force-pushed the jasontedor:fix-control-group-pattern branch to de1fb0b Feb 16, 2017
@jasontedor jasontedor merged commit 00a8b87 into elastic:master Feb 16, 2017
1 of 2 checks passed
1 of 2 checks passed
elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details
jasontedor added a commit that referenced this pull request Feb 16, 2017
The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:
 1. a hierarchy ID number
 2. a comma-separated list of hierarchies
 3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.

Relates #23219
jasontedor added a commit that referenced this pull request Feb 16, 2017
The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:
 1. a hierarchy ID number
 2. a comma-separated list of hierarchies
 3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.

Relates #23219
@jasontedor jasontedor deleted the jasontedor:fix-control-group-pattern branch Feb 16, 2017
@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2017

Thanks @rjernst.

jasontedor added a commit that referenced this pull request Feb 17, 2017
The file /proc/self/cgroup lists the control groups to which the process
belongs. This file is a colon separated list of three fields:
 1. a hierarchy ID number
 2. a comma-separated list of hierarchies
 3. the pathname of the control group in the hierarchy

The regex pattern for this contains a bug for the second field. It
allows one or two entries in the comma-separated list, but not
more. This commit fixes the pattern to allow one or more entires in the
comma-separated list.

Relates #23219
@jasontedor jasontedor added the v5.2.2 label Feb 17, 2017
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Feb 22, 2017
This was addressed in elastic/elasticsearch#23219

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Mar 23, 2017
This was addressed in elastic/elasticsearch#23219

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Mar 27, 2017
This was addressed in elastic/elasticsearch#23219

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Mar 28, 2017
This was addressed in elastic/elasticsearch#23219

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.