Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote support for lucene versions without checksums #24021

Merged
merged 2 commits into from Apr 10, 2017

Conversation

@s1monw
Copy link
Contributor

commented Apr 10, 2017

We are still carrying some legacy code that deals with lucene indices
that don't have checksums. Yet, we do not support these indices
for a while now, in fact since version 5.0 such an index is not supported
anymore. This commit removes all the special handling and leniency involved.

Remote support for lucene versions without checksums
We are still carrying some legacy code that deals with lucene indices
that don't have checksums. Yet, we do not support these indices
for a while now, in fact since version 5.0 such an index is not supported
anymore. This commit removes all the special handling and lenciency involved.
@colings86
Copy link
Member

left a comment

LGTM

@@ -73,7 +63,11 @@ public StoreFileMetaData(StreamInput in) throws IOException {
length = in.readVLong();
checksum = in.readString();
// TODO Why not Version.parse?

This comment has been minimized.

Copy link
@colings86

colings86 Apr 10, 2017

Member

We can remove this comment now?

@jpountz
Copy link
Contributor

left a comment

LGTM

@s1monw s1monw merged commit a61fb3f into elastic:master Apr 10, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@s1monw s1monw deleted the s1monw:remove_support_for_no_checksums branch Apr 10, 2017

@s1monw s1monw removed the v5.4.0 label Apr 11, 2017

@s1monw

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2017

This won't be back-ported to 5.x since we still might have to deal with missing checksums on segments_n files. See #18707 for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.