Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for default settings #24093

Merged
merged 3 commits into from Apr 13, 2017

Conversation

@jasontedor
Copy link
Member

commented Apr 13, 2017

Today Elasticsearch allows default settings to be used only if the actual setting is not set. These settings are trappy, and the complexity invites bugs. This commit removes support for default settings with the exception of default.path.data, default.path.conf, and default.path.logs which are maintainted to support packaging. A follow-up will remove support for these as well.

Relates #23981, relates #24052, relates #24074

Remove support for default settings
Today Elasticsearch allows default settings to be used only if the
actual setting is not set. These settings are trappy, and the complexity
invites bugs. This commit removes support for default settings with the
exception of default.path.data, default.path.conf, and default.path.logs
which are maintainted to support packaging. A follow-up will remove
support for these as well.
@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2017

I will add migration docs when this is backported to the 5.4 branch.

@s1monw
s1monw approved these changes Apr 13, 2017
Copy link
Contributor

left a comment

LGTM

jasontedor added 2 commits Apr 13, 2017

@jasontedor jasontedor merged commit 99e0268 into elastic:master Apr 13, 2017

1 check was pending

elasticsearch-ci Build started sha1 is merged.
Details
jasontedor added a commit that referenced this pull request Apr 13, 2017
Remove support for default settings
Today Elasticsearch allows default settings to be used only if the
actual setting is not set. These settings are trappy, and the complexity
invites bugs. This commit removes support for default settings with the
exception of default.path.data, default.path.conf, and default.path.logs
which are maintainted to support packaging. A follow-up will remove
support for these as well.

Relates #24093
jasontedor added a commit that referenced this pull request Apr 13, 2017
Remove support for default settings
Today Elasticsearch allows default settings to be used only if the
actual setting is not set. These settings are trappy, and the complexity
invites bugs. This commit removes support for default settings with the
exception of default.path.data, default.path.conf, and default.path.logs
which are maintainted to support packaging. A follow-up will remove
support for these as well.

Relates #24093
jasontedor added a commit that referenced this pull request Apr 13, 2017
Remove support for default settings
Today Elasticsearch allows default settings to be used only if the
actual setting is not set. These settings are trappy, and the complexity
invites bugs. This commit removes support for default settings with the
exception of default.path.data, default.path.conf, and default.path.logs
which are maintainted to support packaging. A follow-up will remove
support for these as well.

Relates #24093

@jasontedor jasontedor added the v5.3.1 label Apr 14, 2017

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2017

This was also backported to the 5.3 branch but without removing support for default settings. Instead, the portion of this change that was backported was only to elevate default.path.conf, default.path.data, and default.path.logs to concrete settings.

@jasontedor jasontedor deleted the jasontedor:default-settings branch Apr 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.