Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing for InternalExtendedStats #24284

Conversation

@cbuescher
Copy link
Member

commented Apr 24, 2017

Similar to #24085 this adds parsing for InternalExtendedStats.
PR is against the current feature branch for aggregation parsing.

Relates to #24239.

@cbuescher

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2017

Rebased after merging #24239, this should be ready for review now.

Copy link
Member

left a comment

LGTM besides the small comment I left

commonStatsAssertions(aggregation, parsed);
}

static void commonStatsAssertions(InternalStats aggregation, ParsedStats parsed) {

This comment has been minimized.

Copy link
@javanna

javanna Apr 25, 2017

Member

can you rename this method, I'd like method names to contain a verb which indicates what they do e.g. assertStats ?

This comment has been minimized.

Copy link
@cbuescher

cbuescher Apr 25, 2017

Author Member

sure

@cbuescher cbuescher merged commit 0e31a21 into elastic:feature/client_aggs_parsing Apr 25, 2017
1 check passed
1 check passed
CLA Commit author is a member of Elasticsearch
Details
javanna added a commit to javanna/elasticsearch that referenced this pull request May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.