Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE if field caps request has a field that exists not in all indices #24504

Merged
merged 1 commit into from May 5, 2017

Conversation

@s1monw
Copy link
Contributor

commented May 5, 2017

If a field caps request contains a field name that doesn't exist in all indices
the response will be partial and we hide an NPE. The NPE is now fixed but we still
have the problem that we don't pass on errors on the shard level to the user. This will
be fixed in a followup.

Fix NPE if field caps request has a field that exists not in all indices
IF a field caps request contains a field name that doesn't exist in all indices
the response will be partial and we hide an NPE. The NPE is now fixed but we still
have the problem that we don't pass on errors on the shard level to the user. This will
be fixed in a followup.

@s1monw s1monw requested a review from jimczi May 5, 2017

@jimczi
jimczi approved these changes May 5, 2017
Copy link
Member

left a comment

Thanks for catching this !

@s1monw s1monw merged commit 03267e0 into elastic:master May 5, 2017

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details
s1monw added a commit that referenced this pull request May 5, 2017
Fix NPE if field caps request has a field that exists not in all indi…
…ces (#24504)

If a field caps request contains a field name that doesn't exist in all indices
the response will be partial and we hide an NPE. The NPE is now fixed but we still
have the problem that we don't pass on errors on the shard level to the user. This will
be fixed in a followup.
s1monw added a commit that referenced this pull request May 5, 2017
Fix NPE if field caps request has a field that exists not in all indi…
…ces (#24504)

If a field caps request contains a field name that doesn't exist in all indices
the response will be partial and we hide an NPE. The NPE is now fixed but we still
have the problem that we don't pass on errors on the shard level to the user. This will
be fixed in a followup.

@clintongormley clintongormley added v6.0.0-alpha1 and removed v6.0.0 labels May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.