Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PreConfiguredTokenFilter harder to misuse #24572

Merged
merged 7 commits into from May 11, 2017

Conversation

Projects
None yet
4 participants
@nik9000
Copy link
Contributor

commented May 9, 2017

There are now three public static method to build instances of
PreConfiguredTokenFilter and the ctor is private. I chose static
methods instead of constructors because those allow us to change
out the implementation returned if we so desire.

Also moves over two more pre-configured token filters. There still
a bunch to go!

Relates to #23658

nik9000 added some commits May 9, 2017

Make PreConfiguredTokenFilter harder to misuse
There are now three public static method to build instances of
PreConfiguredTokenFilter and the ctor is private. I chose static
methods instead of constructors because those allow us to change
out the implementation returned if we so desire.

Relates to #23658
@rjernst

rjernst approved these changes May 9, 2017

Copy link
Member

left a comment

LGTM

@@ -36,31 +37,46 @@
* Provides pre-configured, shared {@link TokenFilter}s.
*/
public final class PreConfiguredTokenFilter implements AnalysisModule.AnalysisProvider<TokenFilterFactory> {
/**
* Set up a pre-configured token filter that may no vary at all.

This comment has been minimized.

Copy link
@rjernst

rjernst May 9, 2017

Member

typo: no -> not

@@ -36,31 +37,46 @@
* Provides pre-configured, shared {@link TokenFilter}s.
*/
public final class PreConfiguredTokenFilter implements AnalysisModule.AnalysisProvider<TokenFilterFactory> {
/**
* Set up a pre-configured token filter that may no vary at all.

This comment has been minimized.

Copy link
@rjernst

rjernst May 9, 2017

Member

nit: "Set up" -> "Create"

nik9000 added some commits May 10, 2017

@nik9000 nik9000 merged commit 65f2717 into elastic:master May 11, 2017

1 of 2 checks passed

elasticsearch-ci Build finished.
Details
CLA Commit author has signed the CLA
Details
@nik9000

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2017

From a categorization perspective this issue is about the plugin API more than analysis so I dropped the :Analysis label.

@nik9000 nik9000 referenced this pull request May 11, 2017

Open

Move analysis components to a module #23658

67 of 75 tasks complete

nik9000 added a commit that referenced this pull request May 19, 2017

Allow plugins to register pre-configured tokenizers (#24751)
Allows plugins to register pre-configured tokenizers. Much
of the decisions are the same as those in #24223, #24572,
and #24223. This only migrates the lowercase tokenizer but
I figure that is a good start because it proves out the features.

@nik9000 nik9000 deleted the nik9000:prebuilt_token_filter_2 branch Jun 7, 2017

@colings86 colings86 added v6.0.0-beta1 and removed v6.0.0 labels Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.