New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Fine Grain Settings for Scripts #24573

Merged
merged 10 commits into from May 10, 2017

Conversation

Projects
None yet
3 participants
@jdconrad
Contributor

jdconrad commented May 9, 2017

As the title says. Will be replaced with the settings defined in #24532 in the next PR.

@rjernst

Looks good, but I think this is still missing deprecation on the langAndTypeSetting in ScriptSettings?

@@ -94,6 +97,21 @@ public void assertAllSettingsWereChecked() {
}
}
private static Setting<?>[] buildDeprecatedSettingsArray(ScriptSettings scriptSettings, String... keys) {

This comment has been minimized.

@rjernst

rjernst May 9, 2017

Member

This seems to be common, maybe just put it under one test class as public static?

This comment has been minimized.

@jdconrad

jdconrad May 9, 2017

Contributor

Do you have a class you prefer considering all of these inherit from ESTestCase which didn't seem appropriate?

This comment has been minimized.

@jdconrad

jdconrad May 9, 2017

Contributor

Moved to ScriptSettingsTests

@jdconrad

This comment has been minimized.

Contributor

jdconrad commented May 9, 2017

@rjernst Thought langAndTypeSettng was done at line 110. Did I miss a different place?

@rjernst

This comment has been minimized.

@jdconrad

This comment has been minimized.

Contributor

jdconrad commented May 9, 2017

Think I found them all.

@rjernst

rjernst approved these changes May 9, 2017

Thanks! LGTM

@jdconrad

This comment has been minimized.

Contributor

jdconrad commented May 10, 2017

@elasticmachine please test this

jdconrad added some commits May 10, 2017

@jdconrad jdconrad merged commit 6ac8a1e into elastic:master May 10, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
@jdconrad

This comment has been minimized.

Contributor

jdconrad commented May 10, 2017

@rjernst Thanks for the review!

@jdconrad jdconrad deleted the jdconrad:settings branch May 11, 2017

debadair added a commit to debadair/elasticsearch that referenced this pull request May 16, 2017

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment