Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Netty logging hack #24653

Merged
merged 1 commit into from May 12, 2017

Conversation

@jasontedor
Copy link
Member

commented May 12, 2017

Netty removed a logging guarded we added to prevent a scary logging message. We added a hack to work around this. They've added the guard back, so we can remove the hack now.

Relates #24469, relates netty/netty#5624, netty/netty#6568, netty/netty#6696

Remove Netty logging hack
Netty removed a logging guarded we added to prevent a scary logging
message. We added a hack to work around this. They've added the guard
back, so we can remove the hack now.
@dakrone
Copy link
Member

left a comment

LGTM

@jasontedor jasontedor merged commit 5da9405 into elastic:master May 12, 2017

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details
jasontedor added a commit that referenced this pull request May 12, 2017
Remove Netty logging hack (#24653)
Netty removed a logging guarded we added to prevent a scary logging
message. We added a hack to work around this. They've added the guard
back, so we can remove the hack now.
jasontedor added a commit that referenced this pull request May 12, 2017
Remove Netty logging hack (#24653)
Netty removed a logging guarded we added to prevent a scary logging
message. We added a hack to work around this. They've added the guard
back, so we can remove the hack now.

@jasontedor jasontedor deleted the jasontedor:remove-netty-logging-hack branch May 12, 2017

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.