Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement in InternalAggregationTestCase test setup #24675

Conversation

Projects
None yet
2 participants
@cbuescher
Copy link
Member

commented May 15, 2017

After merging in some changes in master, this improves some of the registry setup in InternalAggregationTestCase.

@javanna
Copy link
Member

left a comment

left a minor comment, LGTM though

test/framework/src/main/java/org/elasticsearch/test/InternalAggregationTestCase.java Outdated
return namedXContents;
}

public List<NamedXContentRegistry.Entry> getNamedXContents() {

This comment has been minimized.

Copy link
@javanna

javanna May 15, 2017

Member

could this one be protected?

This comment has been minimized.

Copy link
@cbuescher

cbuescher May 15, 2017

Author Member

sure

@cbuescher cbuescher force-pushed the cbuescher:small-InternalAggregationTestCase-improvement branch to 27a3979 May 15, 2017

@cbuescher cbuescher merged commit 0b688a8 into elastic:feature/client_aggs_parsing May 15, 2017

1 check passed

CLA Commit author is a member of Elasticsearch
Details

javanna added a commit to javanna/elasticsearch that referenced this pull request May 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.