New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting: Remove native scripts #24726

Merged
merged 8 commits into from May 17, 2017

Conversation

Projects
None yet
4 participants
@rjernst
Member

rjernst commented May 17, 2017

Native scripts have been replaced in documentation by implementing
a ScriptEngine and they were deprecated in 5.5.0. This commit
removes the native script infrastructure for 6.0.

closes #19966

Scripting: Remove native scripts
Native scripts have been replaced in documentation by implementing
a ScriptEngine and they were deprecated in 5.5.0. This commit
removes the native script infrastructure for 6.0.

closes #19966

rjernst added some commits May 17, 2017

@nik9000

I like all the removed lines! I'm fine with pushing folks over to a script engine. @imotov probably should have a look as well if just so that he knows this is happening.

static float[] floatArray = { Float.MAX_VALUE, Float.MIN_VALUE, 3.3f };
static double[] doubleArray = { Double.MAX_VALUE, Double.MIN_VALUE, 3.3d };
public void testNativeScript() throws InterruptedException, ExecutionException {

This comment has been minimized.

@nik9000

nik9000 May 17, 2017

Contributor

I believe we have plenty of tests for script fields hanging around though there may not be any in core if you drop this. Is that a problem, do you think?

@nik9000

nik9000 May 17, 2017

Contributor

I believe we have plenty of tests for script fields hanging around though there may not be any in core if you drop this. Is that a problem, do you think?

This comment has been minimized.

@rjernst

rjernst May 17, 2017

Member

This wasn't really testing script fields per say, but I will double check there is some test for script fields.

@rjernst

rjernst May 17, 2017

Member

This wasn't really testing script fields per say, but I will double check there is some test for script fields.

@imotov

imotov approved these changes May 17, 2017

LGTM

@rjernst rjernst merged commit 26e2e93 into elastic:master May 17, 2017

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details

@rjernst rjernst deleted the rjernst:remove_native_scripts branch May 17, 2017

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment