Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remaining references to scripts directory #24771

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
3 participants
@colings86
Copy link
Member

commented May 18, 2017

The packaging scripts still referenced the scripts directory which is now removed.

remove remaining references to scripts directory
The packaging scripts still referenced the scripts directory which is now removed.
@@ -79,12 +79,6 @@ if [ "$REMOVE_SERVICE" = "true" ]; then
if command -v update-rc.d >/dev/null; then
update-rc.d elasticsearch remove >/dev/null || true
fi

SCRIPTS_DIR="/etc/elasticsearch/scripts"

This comment has been minimized.

Copy link
@colings86

colings86 May 18, 2017

Author Member

Not sure if we should remove this from here since we may need to delete the directory still if the user has upgrade from an older version and the directory still exists

This comment has been minimized.

Copy link
@jasontedor

jasontedor May 18, 2017

Member

This is for package removal. If a user is removing an old version, it is the package removal script from the version that they have installed that will execute. We can safely remove this here.

@colings86

This comment has been minimized.

@jasontedor
Copy link
Member

left a comment

LGTM.

@colings86 colings86 merged commit 779cf3d into elastic:master May 18, 2017

1 check passed

CLA Commit author has signed the CLA
Details

@colings86 colings86 deleted the colings86:fix/packagingScripts branch May 18, 2017

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.