Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document count to Matrix Stats aggregation response #24776

Merged
merged 2 commits into from May 30, 2017

Conversation

Projects
None yet
3 participants
@tlrx
Copy link
Member

commented May 18, 2017

This commit adds a doc_count field to the response body of Matrix Stats aggregation. It exposes the number of documents involved in the computation of statistics, a value that can already be retrieved using
the method MatrixStats.getDocCount() in the Java API.

This information will be useful for the Java High Level Rest Client in order to provide the same level of information as what a user can get using the Transport Client (see #24746 (comment)).

Add document count to Matrix Stats aggregation response
This commit adds a `doc_count` field to the response body of Matrix
Stats aggregation. It exposes the number of documents involved in
 the computation of statistics, a value that can already be retrieved using
  the method MatrixStats.getDocCount() in the Java API.
@javanna
Copy link
Member

left a comment

LGTM I think this is useful to REST clients in general as this info was only returned through transport.

@tlrx tlrx merged commit 28d97df into elastic:master May 30, 2017

1 check passed

elasticsearch-ci Build finished.
Details

@tlrx tlrx deleted the tlrx:matrix-stats-doc-count branch May 30, 2017

@tlrx

This comment has been minimized.

Copy link
Member Author

commented May 30, 2017

Thanks @javanna

tlrx added a commit to tlrx/elasticsearch that referenced this pull request May 30, 2017

Add doc_count to ParsedMatrixStats
This commit adds support in ParsedMatrixStats for parsing the doc_count
field.

Related to elastic#24776

tlrx added a commit that referenced this pull request May 30, 2017

Add doc_count to ParsedMatrixStats (#24952)
This commit adds support in ParsedMatrixStats for parsing the doc_count
field.

Related to #24776

tlrx added a commit that referenced this pull request May 30, 2017

Add document count to Matrix Stats aggregation response (#24776)
This commit adds a `doc_count` field to the response body of Matrix
Stats aggregation. It exposes the number of documents involved in
 the computation of statistics, a value that can already be retrieved using
  the method MatrixStats.getDocCount() in the Java API.

tlrx added a commit that referenced this pull request May 30, 2017

Add doc_count to ParsedMatrixStats (#24952)
This commit adds support in ParsedMatrixStats for parsing the doc_count
field.

Related to #24776

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 30, 2017

Merge branch 'master' into primary-promotion-transition
* master:
  Fix typo in comment in ReplicationOperation.java
  Prevent Index & Delete request primaryTerm getter/setter, setShardId setter
  Drop name from TokenizerFactory (elastic#24869)
  Correctly set doc_count when MovAvg "predicts" values on existing buckets (elastic#24892)
  Handle primary failure handling replica response
  Add missing word to terms-query.asciidoc (elastic#24960)
  Correct some spelling in match-phrase-prefix docs (elastic#24956)
  testConcurrentWriteViewsAndSnapshot shouldn't flush concurrently
  [TEST] Fix FieldSortIT failures
  Add doc_count to ParsedMatrixStats (elastic#24952)
  Add document count to Matrix Stats aggregation response (elastic#24776)
  Fix script field sort returning Double.MAX_VALUE for all documents (elastic#24942)

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.