Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark SearchSourceBuilder as ToXContentObject #24795

Conversation

Projects
None yet
4 participants
@javanna
Copy link
Member

commented May 19, 2017

SearchSourceBuilder#toXContent prints out a complete object, hence it should implement ToXContentObject

Mark SearchSourceBuilder as ToXContentObject
SearchSourceBuilder#toXContent prints out a complete object, hence it should implement ToXContentObject
@@ -1199,7 +1200,7 @@ public void innerToXContent(XContentBuilder builder, Params params) throws IOExc

if (aggregations != null) {
builder.field(AGGREGATIONS_FIELD.getPreferredName(), aggregations);
}
}

This comment has been minimized.

Copy link
@tlrx

tlrx May 19, 2017

Member

Can you merge the toXContent and innerToXContent() methods?

This comment has been minimized.

Copy link
@javanna

javanna May 19, 2017

Author Member

good point, done!

@cbuescher
Copy link
Member

left a comment

LGTM

@tlrx

tlrx approved these changes May 19, 2017

@javanna javanna merged commit ae73670 into elastic:master May 19, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

javanna added a commit that referenced this pull request May 19, 2017

Mark SearchSourceBuilder as ToXContentObject (#24795)
SearchSourceBuilder#toXContent prints out a complete object, hence it should implement ToXContentObject

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.