Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating-point error when DateProcessor parses UNIX #24947

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
5 participants
@talevy
Copy link
Contributor

commented May 30, 2017

DateProcessor's DateFormat UNIX format parser resulted in
a floating point rounding error when parsing certain stringed
epoch times. Now Double.parseDouble is used, preserving the
intended input.

Fix floating-point error when DateProcessor parses UNIX
DateProcessor's DateFormat UNIX format parser resulted in
a floating point rounding error when parsing certain stringed
epoch times. Now Double.parseDouble is used, preserving the
intented input.
@rjernst
Copy link
Member

left a comment

LGTM

@martijnvg
Copy link
Member

left a comment

LGTM

@talevy talevy merged commit 2a6e686 into elastic:master May 30, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

talevy added a commit that referenced this pull request May 30, 2017

Fix floating-point error when DateProcessor parses UNIX (#24947)
DateProcessor's DateFormat UNIX format parser resulted in
a floating point rounding error when parsing certain stringed
epoch times. Now Double.parseDouble is used, preserving the
intented input.

@talevy talevy deleted the talevy:fix-date-error branch May 30, 2017

@clintongormley clintongormley added v6.0.0-alpha2 and removed v6.0.0 labels Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.