Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
GET aliases should 404 if aliases are missing #25043
Previously the HEAD and GET aliases endpoints were misaligned in behavior. The HEAD verb would 404 if any aliases are missing while the GET verb would not if any aliases existed. When HEAD was aligned with GET, this broke the previous usage of HEAD to serve as an existence check for aliases. It is the behavior of GET that is problematic here though, if any alias is missing the request should 404. This commit addresses this by modifying the behavior of GET to behave in this way. This fixes the behavior for HEAD to also 404 when aliases are missing.
@dakrone I don't think this is how we should do things because then this branch can never get to green until this is backported to 5.x. Instead:
Jun 6, 2017
You're very welcome, and sorry for the issue in the first place.
That's all correct.