Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant and broken MD5 checksum from repository-s3 #25270

Merged
merged 2 commits into from Jun 21, 2017

Conversation

@joachimdraeger
Copy link
Contributor

commented Jun 16, 2017

Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. #25269

Remove redundant and not resettable (fails on retries) check-summing.…
… Checksums are calculated and compared by the S3 client already. #25269
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jun 16, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@pickypg

This comment has been minimized.

Copy link
Member

commented Jun 16, 2017

@dadoonet You probably know the most about this?

@joachimdraeger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 21, 2017

@abeyad, did you have a chance to have a look? Thanks.

@abeyad
abeyad approved these changes Jun 21, 2017
Copy link
Contributor

left a comment

LGTM, great find @joachimdraeger ! Thank you for reporting and fixing it.

@abeyad abeyad merged commit 98b0267 into elastic:master Jun 21, 2017

1 check passed

CLA Commit author has signed the CLA
Details
abeyad pushed a commit that referenced this pull request Jun 21, 2017
Remove redundant and broken MD5 checksum from repository-s3 (#25270)
Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. 

Closes #25269
abeyad pushed a commit that referenced this pull request Jun 21, 2017
Remove redundant and broken MD5 checksum from repository-s3 (#25270)
Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. 

Closes #25269
abeyad pushed a commit that referenced this pull request Jun 21, 2017
Remove redundant and broken MD5 checksum from repository-s3 (#25270)
Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. 

Closes #25269
@abeyad

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2017

5.x commit: b73adbe
5.5 commit: 280014a
5.4 commit: 913badd

@joachimdraeger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2017

Thanks for your review and merge, @abeyad

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jun 22, 2017
Merge branch 'master' into primary-context
* master: (56 commits)
  Initialize max unsafe auto ID timestamp on shrink
  Enable a long translog retention policy by default (elastic#25294)
  Remove `index.mapping.single_type=false` from core/tests (elastic#25331)
  test: single type defaults to true since alpha1 and not alpha3
  Get short path name for native controllers
  Live primary-replica resync (no rollback) (elastic#24841)
  Upgrade to lucene-7.0.0-snapshot-ad2cb77. (elastic#25349)
  percolator: Deprecate `document_type` parameter.
  [DOCS] Fixed typo.
  [rest-api-spec/indices.refresh] Remove old params
  Remove redundant and broken MD5 checksum from repository-s3 (elastic#25270)
  Initialize sequence numbers on a shrunken index
  Port most snapshot/restore static bwc tests to qa:full-cluster-restart (elastic#25296)
  Javadoc: ThreadPool doesn't reject while shutdown (elastic#23678)
  test: verify `size_to_upgrade_in_bytes` in assertBusy(...)
  Docs: Removed duplicated line in mapping docs
  Add backward compatibility indices for 5.4.2
  Update MockTransportService to the age of Transport.Connection (elastic#25320)
  Add version v5.4.2 after release
  IndexMetaData: Add internal format index setting (elastic#25292)
  ...

@clintongormley clintongormley added the >bug label Jun 27, 2017

utkarshsins added a commit to rahul1193/elasticsearch that referenced this pull request Jun 29, 2017
Remove redundant and broken MD5 checksum from repository-s3 (elastic#…
…25270)

Remove redundant and not resettable (fails on retries) check-summing. Checksums are calculated and compared by the S3 client already. 

Closes elastic#25269

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.