Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parent id being specified as number in the _source #25547

Conversation

Projects
None yet
4 participants
@martijnvg
Copy link
Member

commented Jul 5, 2017

If the parent id is now specified as a number then this leads to an error during indexing. This maybe unexpected as incremental ids are very common.

@jimczi

jimczi approved these changes Jul 6, 2017

Copy link
Member

left a comment

LGTM

@martijnvg

This comment has been minimized.

Copy link
Member Author

commented Jul 6, 2017

Pushed to master branch: 407273f
and 5.x branch: ba94d28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.