Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason to global checkpoint updates on replica #25612

Merged

Conversation

Projects
None yet
3 participants
@jasontedor
Copy link
Member

commented Jul 7, 2017

Updating the global checkpoint on a replica can occur for a few different reasons:

  • from inlined global checkpoint updates
  • from a primary term transition
  • from finalizing recovery

Yet, the trace logging for a global checkpoint update does not present this information that can be useful when tracing test failures. This commit adds a reason for the global checkpoint update on a replica so that we can trace these updates.

Relates #10708

Add reason to global checkpoint updates on replica
Updating the global checkpoint on a replica can occur for a few
different reasons:
 - from inlined global checkpoint updates
 - from a primary term transition
 - from finalizing recovery

Yet, the trace logging for a global checkpoint update does not present
this information that can be useful when tracing test failures. This
commit adds a reason for the global checkpoint update on a replica so
that we can trace these updates.

jasontedor added some commits Jul 8, 2017

@bleskes

bleskes approved these changes Jul 8, 2017

@jasontedor jasontedor merged commit cb3674c into elastic:master Jul 8, 2017

1 of 2 checks passed

elasticsearch-ci Build finished.
Details
CLA Commit author is a member of Elasticsearch
Details

@jasontedor jasontedor deleted the jasontedor:global-checkpoint-update-reason branch Jul 8, 2017

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.