Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes FieldStats API #25628

Merged
merged 3 commits into from Jul 13, 2017

Conversation

@colings86
Copy link
Member

commented Jul 10, 2017

Closes #25577

@jimczi
jimczi approved these changes Jul 10, 2017
Copy link
Member

left a comment

LGTM

@colings86 colings86 force-pushed the colings86:remove/fieldStatsAPI branch Jul 10, 2017
@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2017

@colings86 @jimczi @clintongormley I think we can merge this now given elastic/kibana#12814 and #25658 /cc @epixa @spalger ?

@colings86 colings86 force-pushed the colings86:remove/fieldStatsAPI branch Jul 13, 2017
@colings86

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2017

@s1monw agreed, I just rebased to fix a merge conflict so as soon as the build passes I'll merge this

@s1monw

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2017

@colings86 lets wait for thumbs-up from @epixa or @spalger

colings86 added 3 commits Jul 6, 2017
@colings86 colings86 force-pushed the colings86:remove/fieldStatsAPI branch to ce490ba Jul 13, 2017
@colings86

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2017

ok will do

@epixa

This comment has been minimized.

Copy link
Member

commented Jul 13, 2017

Thanks

Thumbs up

@colings86 colings86 merged commit 11477a6 into elastic:master Jul 13, 2017
2 checks passed
2 checks passed
CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details
@colings86 colings86 deleted the colings86:remove/fieldStatsAPI branch Jul 13, 2017
@colings86

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2017

Thanks @epixa, this is now merged into master 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.