Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the scope of `QueryRewriteContext` #25787

Merged
merged 2 commits into from Jul 19, 2017

Conversation

Projects
None yet
3 participants
@s1monw
Copy link
Contributor

commented Jul 19, 2017

Today we provide a lot of functionality on the QueryRewriteContext that
we potentially don't have ie. if we rewrite on a coordinating node or when
we percolating. This change moves most of the unnecessary shard level or
index level services and dependencies to QueryShardContext instead.

Reduce the scope of `QueryRewriteContext`
Today we provide a lot of functinality on the QueryRewirteContext that
we potentially don't have ie. if we rewrite on a coordinating node or when
we percolating. This change moves most of the unnecessary shard level or
index level services and dependencies to `QueryShardContext` instead.
@colings86
Copy link
Member

left a comment

LGTM

@s1monw s1monw merged commit 9882d2b into elastic:master Jul 19, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@s1monw s1monw deleted the s1monw:reduce_rewrite_context_scope branch Jul 19, 2017

@clintongormley clintongormley added v6.0.0-beta1 and removed v6.0.0 labels Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.