Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup IndexFieldData visibility #25900

Merged
merged 3 commits into from Jul 26, 2017

Conversation

Projects
None yet
5 participants
@s1monw
Copy link
Contributor

commented Jul 26, 2017

Today we expose IndexFieldDataService outside of IndexService to do maintainance
or lookup field data in different ways. Yet, we have a streamlined way to access IndexFieldData
via QueryShardContext that should encapsulate all access to it. This also ensures that we control
all other functionality like cache clearing etc.

This change also removes the recycler option from ClearIndicesCacheRequest this option is a no-op and should have been removed long ago.

Cleanup IndexFieldData visibility
Today we expose `IndexFieldDataService` outside of IndexService to do maintainance
or lookup field data in different ways. Yet, we have a streamlined way to access IndexFieldData
via `QueryShardContext` that should encapsulate all access to it. This also ensures that we control
all other functionality like cache clearing etc.

This change also removes the `recycler` option from `ClearIndicesCacheRequest` this option is a no-op
and should have been removed long ago.
private boolean requestCache = false;
private String[] fields = null;

private String[] fields = Strings.EMPTY_ARRAY;

This comment has been minimized.

Copy link
@jpountz

jpountz Jul 26, 2017

Contributor

that change alone makes me happy

indexFieldData.clearField(field);
}
}
}

This comment has been minimized.

Copy link
@jpountz

jpountz Jul 26, 2017

Contributor

I see you did not change that logic but it confuses me a bit as it seems we always clear fileddata even when fieldDataCache is false?

This comment has been minimized.

Copy link
@s1monw

s1monw Jul 26, 2017

Author Contributor

yeah we are on the same page. I will open a followup with a BWC break

@jimczi

jimczi approved these changes Jul 26, 2017

Copy link
Member

left a comment

LGTM for the code, tests failed to compile ;)

@s1monw s1monw merged commit b72c710 into elastic:master Jul 26, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

s1monw added a commit that referenced this pull request Jul 26, 2017

Cleanup IndexFieldData visibility (#25900)
Today we expose `IndexFieldDataService` outside of IndexService to do maintenance
or lookup field data in different ways. Yet, we have a streamlined way to access IndexFieldData
via `QueryShardContext` that should encapsulate all access to it. This also ensures that we control all other functionality like cache clearing etc.

This change also removes the `recycler` option from `ClearIndicesCacheRequest` this option is a no-op and should have been removed long ago.

s1monw added a commit that referenced this pull request Jul 26, 2017

Cleanup IndexFieldData visibility (#25900)
Today we expose `IndexFieldDataService` outside of IndexService to do maintenance
or lookup field data in different ways. Yet, we have a streamlined way to access IndexFieldData
via `QueryShardContext` that should encapsulate all access to it. This also ensures that we control all other functionality like cache clearing etc.

This change also removes the `recycler` option from `ClearIndicesCacheRequest` this option is a no-op and should have been removed long ago.

@colings86 colings86 added v6.0.0-beta1 and removed v6.0.0 labels Jul 31, 2017

@lcawl lcawl removed the v6.1.0 label Dec 12, 2017

@jpountz jpountz added the >non-issue label Jan 29, 2019

@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.