Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching a MinDocQuery can lead to wrong results. #25909

Merged
merged 2 commits into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@jpountz
Copy link
Contributor

commented Jul 26, 2017

Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.

Caching a MinDocQuery can lead to wrong results.
Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.

@jpountz jpountz requested a review from jimczi Jul 26, 2017

@jimczi

jimczi approved these changes Jul 26, 2017

Copy link
Member

left a comment

Good catch, thanks !

@jpountz jpountz merged commit 1cd5e34 into elastic:master Jul 27, 2017

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details

@jpountz jpountz deleted the jpountz:fix/min_doc_query_caching branch Jul 27, 2017

jpountz added a commit that referenced this pull request Jul 27, 2017

Caching a MinDocQuery can lead to wrong results. (#25909)
Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.

jpountz added a commit that referenced this pull request Jul 27, 2017

Caching a MinDocQuery can lead to wrong results. (#25909)
Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.

jpountz added a commit that referenced this pull request Jul 27, 2017

Caching a MinDocQuery can lead to wrong results. (#25909)
Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.

@colings86 colings86 added v6.0.0-beta1 and removed v6.0.0 labels Jul 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.