Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make calls to CloudBlobContainer#exists privileged #25937

Merged
merged 1 commit into from Jul 28, 2017

Conversation

@tbrooks8
Copy link
Contributor

commented Jul 27, 2017

This is related to #25931. In CloudBlobContainer#exists it is possible
that a socket connection will be opened. This commit ensures that those
calls have the proper socket privileges.

This is related to #25931. In CloudBlobContainer#exists it is possible
that a socket connection will be opened. This commit ensures that those
calls have the proper socket privileges.
@dadoonet

This comment has been minimized.

Copy link
Member

commented Jul 27, 2017

@tbrooks8 I'm going to test your branch on azure platform and I'll report back here.

@tbrooks8

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2017

Thanks. That would be great. These apis are kind of very "abstraction" oriented and do not always make it clear if they are opening connections.

@dadoonet dadoonet self-requested a review Jul 27, 2017
@dadoonet dadoonet self-assigned this Jul 27, 2017
Copy link
Member

left a comment

I tested it against an azure storage account and I've been able to snapshot an index on azure.

Copy link
Member

left a comment

LGTM.

@tbrooks8 tbrooks8 merged commit 7d2d6bd into elastic:master Jul 28, 2017
2 checks passed
2 checks passed
CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
@dadoonet

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

@tbrooks8 I see that you merged it in master branch. I believe it should be merged as well in 6.0 and 6.x branches, right?

jasontedor added a commit that referenced this pull request Jul 28, 2017
This is related to #25931. In CloudBlobContainer#exists it is possible
that a socket connection will be opened. This commit ensures that those
calls have the proper socket privileges.
jasontedor added a commit that referenced this pull request Jul 28, 2017
This is related to #25931. In CloudBlobContainer#exists it is possible
that a socket connection will be opened. This commit ensures that those
calls have the proper socket privileges.
@jasontedor

This comment has been minimized.

Copy link
Member

commented Jul 28, 2017

@dadoonet I backported this to 6.0 and 6.x.

@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
@tbrooks8 tbrooks8 deleted the tbrooks8:fix_azure branch Nov 14, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.