Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes array out of bounds for value count agg #26038

Merged
merged 1 commit into from Aug 3, 2017

Conversation

@colings86
Copy link
Member

commented Aug 3, 2017

#17379 fixed many metric aggs so that if the parent aggregation does not collect any documents an empty bucket value is returned instead of an ArrayOutOfBoundsException being thrown. Unfortunately the value count aggregation was mised from this fix.

This change applies this fix from #17379 for the value count aggregation.

Fixes array out of bounds for value count agg
#17379 fixed many metric aggs so that if the parent aggregation does not collect any documents an empty bucket value is returned instead of an ArrayOutOfBoundsException being thrown. Unfortunately the value count aggregation was mised from this fix.

This change applies this fix from #17379 for the value count aggregation.
@martijnvg
Copy link
Member

left a comment

LGTM

@colings86 colings86 merged commit 5f1634d into elastic:master Aug 3, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details
colings86 added a commit that referenced this pull request Aug 3, 2017
Fixes array out of bounds for value count agg (#26038)
#17379 fixed many metric aggs so that if the parent aggregation does not collect any documents an empty bucket value is returned instead of an ArrayOutOfBoundsException being thrown. Unfortunately the value count aggregation was mised from this fix.

This change applies this fix from #17379 for the value count aggregation.
colings86 added a commit that referenced this pull request Aug 3, 2017
Fixes array out of bounds for value count agg (#26038)
#17379 fixed many metric aggs so that if the parent aggregation does not collect any documents an empty bucket value is returned instead of an ArrayOutOfBoundsException being thrown. Unfortunately the value count aggregation was mised from this fix.

This change applies this fix from #17379 for the value count aggregation.
colings86 added a commit that referenced this pull request Aug 3, 2017
Fixes array out of bounds for value count agg (#26038)
#17379 fixed many metric aggs so that if the parent aggregation does not collect any documents an empty bucket value is returned instead of an ArrayOutOfBoundsException being thrown. Unfortunately the value count aggregation was mised from this fix.

This change applies this fix from #17379 for the value count aggregation.
colings86 added a commit that referenced this pull request Aug 3, 2017
Fixes array out of bounds for value count agg (#26038)
#17379 fixed many metric aggs so that if the parent aggregation does not collect any documents an empty bucket value is returned instead of an ArrayOutOfBoundsException being thrown. Unfortunately the value count aggregation was mised from this fix.

This change applies this fix from #17379 for the value count aggregation.
colings86 added a commit that referenced this pull request Aug 3, 2017
Fixes array out of bounds for value count agg (#26038)
#17379 fixed many metric aggs so that if the parent aggregation does not collect any documents an empty bucket value is returned instead of an ArrayOutOfBoundsException being thrown. Unfortunately the value count aggregation was mised from this fix.

This change applies this fix from #17379 for the value count aggregation.

@colings86 colings86 deleted the colings86:fix/valueCountAgg branch Aug 3, 2017

@colings86 colings86 added v6.0.0-beta1 and removed v6.0.0 labels Aug 4, 2017

@mellieA

This comment has been minimized.

Copy link
Member

commented Aug 7, 2017

The customer is on 2.4 and is developing a new feature. They say that this bug is blocking them from releasing it, is there any possibility that 2.4.7 would be released with this fix?

Thanks!

Melori

@colings86

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2017

The 2.4 branch is not under active development and so new releases in 2.4.x series would only be done if there is a very serious bug. I don't think this bug warrants a release of 2.4.x on its own and so would only be released in 2.4 if another bug caused a release. In fact, thinking again about the policy for back-porting I actually think I should not have back-ported this to 2.4 since it is not a serious show-stopping bug. If the user needs a fix to this issue I would encourage them to upgrade to 5.5.2 or 5.6 when they are released.

@mellieA

This comment has been minimized.

Copy link
Member

commented Aug 9, 2017

Thanks for the reply @colings86

@lcawl lcawl removed the v6.1.0 label Dec 12, 2017

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.