Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fail query when a sort is provided in conjunction with rescorers #26510
This change fixes a regression introduced in 6 that removes the skipping of the rescore phase
Probably better than just skipping the rescore phase even though this is documented:
I think we should fail if there is a sort criteria other than _score. Rescorers need to resort the topdocs and if they do it wrong this can break the merge sort in the coordinating node. With custom rescorers I think it's good to keep it simple, rescorers work only when sort is not provided and fail otherwise ?