Allow aggregation sorting via nested aggregation #26683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
:Analytics/Aggregations
colings86
approved these changes
Sep 18, 2017
| this.sub = sub; | ||
| this.parentDocs = parentDocs; | ||
| this.childDocs = childDocs; | ||
| // System.out.println("new"); |
There was a problem hiding this comment.
I guess this should be removed?
| final long[] buffer = buckets.buffer; | ||
| final int size = buckets.size(); | ||
| for (int i = 0; i < size; i++) { | ||
| // System.out.println("parentDoc=" + parentDoc +" childDocId=" + childDocId + " bucketOrd=" + buffer[i]); |
There was a problem hiding this comment.
I guess this should be removed?
|
woo hoo! Thank you @martijnvg @colings86! Very nice. |
mattweber
reviewed
Sep 18, 2017
| } | ||
| }; | ||
| } else { | ||
| if (bufferingNestedLeafBucketCollector != null) { |
There was a problem hiding this comment.
can you just call doPostCollection()?
martijnvg
force-pushed
the
aggs_order_via_nested_agg
branch
from
15b0fe5
to
1318206
Compare
The nested aggregator now buffers all bucket ords per parent document and emits all bucket ords for a parent document's nested document once. This way the nested documents document DocIdSetIterator gets used once per bucket instead of wrapping the nested aggregator inside a multi bucket aggregator, which was the current solution upto now. This allows sorting by buckets under a nested bucket. Closes elastic#16838
martijnvg
force-pushed
the
aggs_order_via_nested_agg
branch
from
1318206
to
61849a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nested aggregator now buffers all bucket ords per parent document and
emits all bucket ords for a parent document's nested document once. This way
the nested documents document DocIdSetIterator gets used once per bucket
instead of wrapping the nested aggregator inside a multi bucket aggregator,
which was the current solution upto now. This allows sorting by buckets
under a nested bucket.
PR for #16838