New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove several parse field deprecations in query builders #26711

Merged
merged 6 commits into from Sep 20, 2017

Conversation

Projects
None yet
5 participants
@cbuescher
Member

cbuescher commented Sep 19, 2017

This change removes parse fields that are either completely deprecated since version 5.0 or removes deprecated names.
This PR is opened against master, but should be backported to the 6.x and 6.0 branches with additional notes
to the migration docs in 6.0.

Show outdated Hide outdated core/src/main/java/org/elasticsearch/index/query/MatchQueryBuilder.java
@jimczi

Thanks for doing this @cbuescher !
I left some comments.

Show outdated Hide outdated core/src/main/java/org/elasticsearch/index/query/MatchQueryBuilder.java
Show outdated Hide outdated core/src/main/java/org/elasticsearch/index/query/MatchQueryBuilder.java
Show outdated Hide outdated core/src/main/java/org/elasticsearch/index/query/MatchQueryBuilder.java
Show outdated Hide outdated core/src/main/java/org/elasticsearch/index/query/MatchQueryBuilder.java

cbuescher added some commits Sep 19, 2017

Remove deprecated fields in RangeQueryBuilder
The `fielddata` field and the use of the `_name` field in the short syntax of
the range query have been deprecated in 5.0 and can be removed.
Remove deprecated alternative names of several parse fields
All of these have already been deprecated in 5.0 and can thus be removed in 6.0.
@cbuescher

This comment has been minimized.

Show comment
Hide comment
@cbuescher

cbuescher Sep 20, 2017

Member

@jimczi thanks for the review, I pulled out the changes in the MatchQueryBuilder and related test into #26720 to make this PR a little smaller and easier to backport. Is there anything to the remaining part you would like to be changed? I was planning to add the notes to the migration docs only when backporting to the 6.0 branch.

Member

cbuescher commented Sep 20, 2017

@jimczi thanks for the review, I pulled out the changes in the MatchQueryBuilder and related test into #26720 to make this PR a little smaller and easier to backport. Is there anything to the remaining part you would like to be changed? I was planning to add the notes to the migration docs only when backporting to the 6.0 branch.

@cbuescher cbuescher removed the >deprecation label Sep 20, 2017

@jimczi

jimczi approved these changes Sep 20, 2017

LGTM

@cbuescher cbuescher merged commit 86b00b8 into elastic:master Sep 20, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

cbuescher added a commit that referenced this pull request Sep 20, 2017

Remove parse field deprecations in query builders (#26711)
The `fielddata` field and the use of the `_name` field in the short syntax of the range
query have been deprecated in 5.0 and can be removed.

The same goes for the deprecated `score_mode` field in HasParentQueryBuilder,
the deprecated `like_text`, `ids` and `docs` parameter in the `more_like_this` query,
the deprecated query name in the short version of the `regexp` query, and several
deprecated alternative field names in other query builders.

cbuescher added a commit that referenced this pull request Sep 20, 2017

Remove parse field deprecations in query builders (#26711)
The `fielddata` field and the use of the `_name` field in the short syntax of the range
query have been deprecated in 5.0 and can be removed.

The same goes for the deprecated `score_mode` field in HasParentQueryBuilder,
the deprecated `like_text`, `ids` and `docs` parameter in the `more_like_this` query,
the deprecated query name in the short version of the `regexp` query, and several
deprecated alternative field names in other query builders.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 20, 2017

Merge branch 'master' into global-checkpoint-sync
* master:
  [DOCS] Added index-shared4 and index-shared5.asciidoc
  BulkProcessor flush runnable preserves the thread context from creation time (elastic#26718)
  Catch exceptions and inform handler in RemoteClusterConnection#collectNodes (elastic#26725)
  [Docs] Fix name of character filter in example. (elastic#26724)
  Remove parse field deprecations in query builders (elastic#26711)
  elastic#26720: Set the correct bwc version after backport to 6.0
  Remove deprecated type and slop field in MatchQueryBuilder (elastic#26720)
  Refactoring of Gateway*** classes (elastic#26706)
  Make RestHighLevelClient's Request class public (elastic#26627)
  Deguice ActionFilter (elastic#26691)
  aggs: Allow aggregation sorting via nested aggregation.
  Build: Set bwc builds to always set snapshot (elastic#26704)
  File Discovery: Remove fallback with zen discovery (elastic#26667)

@colings86 colings86 added v6.0.0-rc1 >breaking and removed v6.0.0 labels Sep 22, 2017

@lcawl lcawl removed the v6.1.0 label Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment