New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #26771: beider_morse phonetic encoder failure when languageset unspecified #26848
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
I added the other email address to my github profile. This should fix the CLA check failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkazez thanks for opening this PR, the fix looks good at first looks, but can you also add a unit test that checks the expected behaviour? Some of the other TokenFilterFactoryTests in org.lasticsearch.index.analysis
are probably a good start.
@bkazez also regarding the failing CLA check, I was able to see your Github user and the associated email in our CLA database, but its not the email adress you used in the commit, so can you re-check that your Github profile contains the email adress you signed the CLA with or change the commit email adress accordingly? |
…ecified elastic#26771 (fix author)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkazez the CLA check looks good now, if you could add a unit test for this change we can merge it. If you have any questions please let me know.
@bkazez are you still interested to work on this? I think adding a simple unit test is enought to get this in. |
Sorry, I don't know the testing framework at all (or even Java/Eclipse
particularly well) and I don't think I will have time the next while to
learn it since I've just started a graduate program. It would be great if
someone else could write a quick test so we could get this in.
…On Wed, Oct 18, 2017 at 4:16 PM, Christoph Büscher ***@***.*** > wrote:
@bkazez <https://github.com/bkazez> are you still interested to work on
this? I think adding a simple unit test is enought to get this in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26848 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD6Bbo0B1Tp1DtwgdT9ong9Bh5enUNHks5sthZmgaJpZM4Pp64d>
.
|
This closes #26771. Based on jpountz's analysis: check languageset is neither null nor the empty array.
The previous behaviour was for an empty languageset array to cause the original tokens to be returned. Now, an empty languageset array will function the same as a non-existent languageset and trigger automatic language detection. This ensures that beider_morse phonetic encoder always returns a phonetic encoding of SOME sort, and that it matches the documented behavior.