Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the grok patterns to be consistent with the logstash #27181

Conversation

Projects
None yet
8 participants
@elasticmachine

This comment has been minimized.

Copy link

commented Oct 30, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ywelsch ywelsch requested a review from talevy Nov 15, 2017

@talevy

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2017

thanks for the PR @austintp. mind signing our CLA? Once you do, I will be happy to merge your changes and follow-up with a full-resync of the logstash-patterns-core repo into Ingest Node.

@austintp

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2017

@talevy - Sorry for the delay. I've now signed the CLA.

@karmi

This comment has been minimized.

Copy link
Member

commented Dec 30, 2017

Hi @austintp, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@elasticmachine

This comment has been minimized.

Copy link

commented Dec 30, 2017

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@austintp

This comment has been minimized.

Copy link
Contributor Author

commented Dec 30, 2017

@karmi Done.

@jakelandis jakelandis self-requested a review Dec 6, 2018

@pcsanwald

This comment has been minimized.

Copy link
Contributor

commented Jan 3, 2019

@jakelandis will you review this PR?

@jakelandis

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

@elasticmachine ok to test

@jakelandis jakelandis added the v7.0.0 label Jan 31, 2019

@jakelandis

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

@elasticmachine test this please

@jakelandis

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

@elasticmachine run elasticsearch-ci/1

jakelandis added some commits Feb 5, 2019

@jakelandis

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

@elasticmachine run elasticsearch-ci/1
@elasticmachine run elasticsearch-ci/2

@jakelandis

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

@elasticmachine run elasticsearch-ci/1

@jakelandis
Copy link
Contributor

left a comment

thanks for the PR @austintp ! (sorry it took so long to adopt)

One minor change reversal of the change to TIMESTAMP_ISO8601 (i.e. it is not getting updated) to help preserve passivity within the ingest node.

@jakelandis jakelandis merged commit 8ebff05 into elastic:master Feb 5, 2019

6 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019

Merge branch 'master' into retention-leases-recovery
* master: (23 commits)
  Lift retention lease expiration to index shard (elastic#38380)
  Make Ccr recovery file chunk size configurable (elastic#38370)
  Prevent CCR recovery from missing documents (elastic#38237)
  re-enables awaitsfixed datemath tests (elastic#38376)
  Types removal fix FullClusterRestartIT warnings (elastic#38445)
  Make sure to reject mappings with type _doc when include_type_name is false. (elastic#38270)
  Updates the grok patterns to be consistent with logstash (elastic#27181)
  Ignore type-removal warnings in XPackRestTestHelper (elastic#38431)
  testHlrcFromXContent() should respect assertToXContentEquivalence() (elastic#38232)
  add basic REST test for geohash_grid (elastic#37996)
  Remove DiscoveryPlugin#getDiscoveryTypes (elastic#38414)
  Fix the clock resolution to millis in GetWatchResponseTests (elastic#38405)
  Throw AssertionError when no master (elastic#38432)
  `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API (elastic#38411)
  Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale (elastic#38394)
  Fix failures in BulkProcessorIT#testGlobalParametersAndBulkProcessor. (elastic#38129)
  SQL: Implement CURRENT_DATE (elastic#38175)
  Mute testReadRequestsReturnLatestMappingVersion (elastic#38438)
  [ML] Report index unavailable instead of waiting for lazy node (elastic#38423)
  Update Rollup Caps to allow unknown fields (elastic#38339)
  ...

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.