New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implementations of `TransportChannel` #27388

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
3 participants
@tbrooks8
Contributor

tbrooks8 commented Nov 14, 2017

Right now we have unnecessary implementations of TransportChannel.
Additionally, there are methods on the interface that are not used. This
commit removes unnecessary implementations and methods.

Remove implementations of `TransportChannel`
Right now we have unnecessary implementations of `TransportChannel`.
Additionally, there are methods on the interface that are not used. This
commit removes unnecessary implementations and methods.
@jasontedor

LGTM.

@s1monw

s1monw approved these changes Nov 15, 2017

@tbrooks8 tbrooks8 merged commit a8f9169 into elastic:master Nov 15, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

tbrooks8 added a commit that referenced this pull request Nov 15, 2017

Remove implementations of `TransportChannel` (#27388)
Right now we have unnecessary implementations of `TransportChannel`.
Additionally, there are methods on the interface that are not used. This
commit removes unnecessary implementations and methods.

jasontedor added a commit that referenced this pull request Nov 16, 2017

Merge branch 'master' into ccr
* master:
  Stop skipping REST test after backport of #27056
  Fix default value of ignore_unavailable for snapshot REST API (#27056)
  Add composite aggregator (#26800)
  Fix `ShardSplittingQuery` to respect nested documents. (#27398)
  [Docs] Restore section about multi-level parent/child relation in parent-join (#27392)
  Add TcpChannel to unify Transport implementations (#27132)
  Add note on plugin distributions in plugins folder
  Remove implementations of `TransportChannel` (#27388)
  Update Google SDK to version 1.23 (#27381)
  Fix Gradle 4.3.1 compatibility for logging (#27382)
  [Test] Change Elasticsearch startup timeout to 120s in packaging tests
  Docs/windows installer (#27369)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment