New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal channel tracking in transports #27711

Merged
merged 2 commits into from Dec 8, 2017

Conversation

Projects
None yet
2 participants
@tbrooks8
Contributor

tbrooks8 commented Dec 7, 2017

This commit attempts to continue unifying the logic between different
transport implementations. As transports call a TcpTransport callback
when a new channel is accepted, there is no need to internally track
channels accepted. Instead there is a set of accepted channels in
TcpTransport. This set is used for metrics and shutting down channels.

Remove internal channel tracking in transports
This commit attempts to continue unifying the logic between different
transport implementations. As transports call a `TcpTransport` callback
when a new channel is accepted, there is no need to internally track
channels accepted. Instead there is a set of accepted channels in
`TcpTransport`. This set is used for metrics and shutting down channels.
@jaymode

jaymode approved these changes Dec 8, 2017

LGTM

WIP

@tbrooks8 tbrooks8 merged commit d1acb76 into elastic:master Dec 8, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

tbrooks8 added a commit that referenced this pull request Dec 9, 2017

Remove internal channel tracking in transports (#27711)
This commit attempts to continue unifying the logic between different
transport implementations. As transports call a `TcpTransport` callback
when a new channel is accepted, there is no need to internally track
channels accepted. Instead there is a set of accepted channels in
`TcpTransport`. This set is used for metrics and shutting down channels.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Dec 9, 2017

Merge branch 'master' into disable-package-distribution-integ-tests
* master:
  Fix index with unknown setting test
  Remove internal channel tracking in transports (elastic#27711)
  Improve error msg when a field name contains only white spaces (elastic#27709)
  Do not open indices with broken settings
  Set ACK timeout on indices service test
  Implement byte array reusage in `NioTransport` (elastic#27696)
  [TEST] Remove leftover ES temp directories before Vagrant tests (elastic#27722)
  Cleanup split strings by comma method
  Remove unused import from AliasResolveRoutingIT
  Add read timeouts to http module (elastic#27713)
  Fix routing with leading or trailing whitespace
  remove await fix from FullClusterRestartIT.testRecovery
  Add missing 's' to tmpdir name (elastic#27721)
  [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (elastic#27717)
  [TEST] Now actually wait for merges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment