Fix BWC release tests #27778
Merged
Fix BWC release tests #27778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the release tests, we set build.snapshot to false and this causes all version numbers to not have "-SNAPSHOT". This is true even for the tips of the branches (e.g., currently 5.6.6 on the 5.6 branch). Yet, if we do not set snapshot to false, then we would still be trying to find artifacts with "-SNAPSHOT" appended which would not have been build since build.snapshot is false. To fix this, we have to push build.snapshot into the version logic.
jasontedor
added
:Delivery/Build
DaveCTurner
approved these changes
Dec 12, 2017
ywelsch
approved these changes
Dec 12, 2017
jasontedor
added a commit
that referenced
this pull request
Dec 12, 2017
When running the release tests, we set build.snapshot to false and this causes all version numbers to not have "-SNAPSHOT". This is true even for the tips of the branches (e.g., currently 5.6.6 on the 5.6 branch). Yet, if we do not set snapshot to false, then we would still be trying to find artifacts with "-SNAPSHOT" appended which would not have been build since build.snapshot is false. To fix this, we have to push build.snapshot into the version logic. Relates #27778
jasontedor
added a commit
that referenced
this pull request
Dec 12, 2017
When running the release tests, we set build.snapshot to false and this causes all version numbers to not have "-SNAPSHOT". This is true even for the tips of the branches (e.g., currently 5.6.6 on the 5.6 branch). Yet, if we do not set snapshot to false, then we would still be trying to find artifacts with "-SNAPSHOT" appended which would not have been build since build.snapshot is false. To fix this, we have to push build.snapshot into the version logic. Relates #27778
jasontedor
added a commit
that referenced
this pull request
Dec 12, 2017
When running the release tests, we set build.snapshot to false and this causes all version numbers to not have "-SNAPSHOT". This is true even for the tips of the branches (e.g., currently 5.6.6 on the 5.6 branch). Yet, if we do not set snapshot to false, then we would still be trying to find artifacts with "-SNAPSHOT" appended which would not have been build since build.snapshot is false. To fix this, we have to push build.snapshot into the version logic. Relates #27778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the release tests, we set build.snapshot to false and this causes all version numbers to not have "-SNAPSHOT". This is true even for the tips of the branches (e.g., currently 5.6.6 on the 5.6 branch). Yet, if we do not set snapshot to false, then we would still be trying to find artifacts with "-SNAPSHOT" appended which would not have been build since build.snapshot is false. To fix this, we have to push build.snapshot into the version logic.