Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jvm-example by two plugin examples #28339

Merged
merged 2 commits into from Jan 26, 2018

Conversation

Projects
None yet
6 participants
@tlrx
Copy link
Member

commented Jan 23, 2018

This pull request replaces the jvm-example plugin (from the jvm/site plugins era) by two new plugins: a custom-settings that shows how to register and use custom settings (including secured settings) in a plugin, and rest-handler plugin that shows how to register a rest handler.

The two plugins now reside in the plugins/examples project. They can serve as sample plugins for users, a special attention has been put on documentation. The packaging tests have been adapted to use the custom-settings plugin.

@nik9000
Copy link
Contributor

left a comment

I like it! I left a single comment, but that comment is probably important.

test/framework/src/main/java/org/elasticsearch/test/rest/yaml/ClientYamlTestClient.java Outdated
@@ -100,8 +100,8 @@ public ClientYamlTestResponse callApi(String apiName, Map<String, String> params
queryStringParams.put(entry.getKey(), entry.getValue());
apiRequiredParameters.remove(entry.getKey());
} else {
throw new IllegalArgumentException(
"path/param [" + entry.getKey() + "] not supported by [" + restApi.getName() + "] " + "api");
//throw new IllegalArgumentException(

This comment has been minimized.

Copy link
@nik9000

nik9000 Jan 23, 2018

Contributor

Leftover?

This comment has been minimized.

Copy link
@tlrx

tlrx Jan 23, 2018

Author Member

Definitely, thanks!

@rjernst
Copy link
Member

left a comment

Thank you @tlrx! This is great!

tlrx added some commits Jan 22, 2018

@tlrx tlrx force-pushed the tlrx:replace-jvm-example branch to 7c0977f Jan 26, 2018

@tlrx tlrx merged commit be74f11 into elastic:master Jan 26, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
@tlrx

This comment has been minimized.

Copy link
Member Author

commented Jan 26, 2018

Thanks @nik9000 and @rjernst

@tlrx tlrx added the v6.3.0 label Jan 26, 2018

tlrx added a commit that referenced this pull request Jan 26, 2018

Replace jvm-example by two plugin examples (#28339)
This pull request replaces the jvm-example plugin (from the jvm/site plugins era) by two new plugins: a custom-settings that shows how to register and use custom settings (including secured settings) in a plugin, and rest-handler plugin that shows how to register a rest handler.

The two plugins now reside in the plugins/examples project. They can serve as sample plugins for users, a special attention has been put on documentation. The packaging tests have been adapted to use the custom-settings plugin.

@tlrx tlrx deleted the tlrx:replace-jvm-example branch Jan 26, 2018

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2018

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.