Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix the ability to remove old plugin #28540
We now read the plugin descriptor when removing an old plugin. This is to check if we are removing a plugin that is extended by another plugin. However, when reading the descriptor we enforce that it is of the same version that we are. This is not the case when a user has upgraded Elasticsearch and is now trying to remove an old plugin. This commit fixes this by skipping the version enforcement when reading the plugin descriptor only when removing a plugin.
referenced this pull request
Feb 6, 2018
rjernst left a comment
This looks ok, but I would rather not have 2 variants of readFromProperties. What about moving the enforcement out to another method in install/startup, so reading the properties is just reading properties?
I have mixed feelings about this. Currently we validate everything in