Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable console logging in the Windows service #28618

Merged
merged 1 commit into from Feb 11, 2018

Conversation

@jasontedor
Copy link
Member

commented Feb 10, 2018

When Elasticsearch is run as a service we should not use the console logger otherwise we end up duplicating logging (to the Elasticsearch logs and whereever standard output is captured). Previously we disabled the console logger when started as a service using systemd (otherwise the console logs are duplicated to the journal). This commit does the same for the Windows service, starting Elasticsearch with the --quiet flag to avoid standard output being written to the service stdout logs.

Relates #20422

Disable console logging in the Windows service
When Elasticsearch is run as a service we should not use the console
logger otherwise we end up duplicating logging (to the Elasticsearch
logs and whereever standard output is captured). Previously we disabled
the console logger when started as a service using systemd (otherwise
the console logs are duplicated to the journal). This commit does the
same for the Windows service, starting Elasticsearch with the --quiet
flag to avoid standard output being written to the service stdout logs.
@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Feb 10, 2018

The diff is represented poorly here; the actual change is from

--StopClass org.elasticsearch.bootstrap.Elasticsearch --StartMethod main

to

--StartMethod main ++StartParams --quiet --StopClass org.elasticsearch.bootstrap.Elasticsearch

All other content remains the same.

@jasontedor jasontedor requested a review from rjernst Feb 11, 2018

@rjernst
Copy link
Member

left a comment

Lgtm

@jasontedor jasontedor merged commit 69313ff into elastic:master Feb 11, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
jasontedor added a commit that referenced this pull request Feb 11, 2018
Disable console logging in the Windows service
When Elasticsearch is run as a service we should not use the console
logger otherwise we end up duplicating logging (to the Elasticsearch
logs and whereever standard output is captured). Previously we disabled
the console logger when started as a service using systemd (otherwise
the console logs are duplicated to the journal). This commit does the
same for the Windows service, starting Elasticsearch with the --quiet
flag to avoid standard output being written to the service stdout logs.

Relates #28618
jasontedor added a commit that referenced this pull request Feb 11, 2018
Disable console logging in the Windows service
When Elasticsearch is run as a service we should not use the console
logger otherwise we end up duplicating logging (to the Elasticsearch
logs and whereever standard output is captured). Previously we disabled
the console logger when started as a service using systemd (otherwise
the console logs are duplicated to the journal). This commit does the
same for the Windows service, starting Elasticsearch with the --quiet
flag to avoid standard output being written to the service stdout logs.

Relates #28618
jasontedor added a commit that referenced this pull request Feb 11, 2018
Disable console logging in the Windows service
When Elasticsearch is run as a service we should not use the console
logger otherwise we end up duplicating logging (to the Elasticsearch
logs and whereever standard output is captured). Previously we disabled
the console logger when started as a service using systemd (otherwise
the console logs are duplicated to the journal). This commit does the
same for the Windows service, starting Elasticsearch with the --quiet
flag to avoid standard output being written to the service stdout logs.

Relates #28618

@jasontedor jasontedor deleted the jasontedor:better-be-quiet-now branch Feb 11, 2018

@jasontedor jasontedor added the >bug label Feb 11, 2018

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.