Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using relative custom config path #28700

Merged
merged 1 commit into from Feb 16, 2018

Conversation

@jasontedor
Copy link
Member

commented Feb 15, 2018

Previously a user could set a custom config path to a relative directory using ES_PATH_CONF. In a previous change related to enabling GC logging by default, we forced the working directory for Elasticsearch to be ES_HOME. This had the impact of causing all relative paths to be relative to ES_HOME, against the intent of the user. This commit addresses this by making ES_PATH_CONF absolute before we switch the working directory to ES_HOME.

Relates #27610

Fix using relative custom config path
Previously a user could set a custom config path to a relative directory
using ES_PATH_CONF. In a previous change related to enabling GC logging
by default, we forced the working directory for Elasticsearch to be
ES_HOME. This had the impact of causing all relative paths to be
relative to ES_HOME, against the intent of the user. This commit
addresses this by making ES_PATH_CONF absolute before we switch the
working directory to ES_HOME.
@rjernst
Copy link
Member

left a comment

LGTM

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2018

run the packaging tests

@talevy
talevy approved these changes Feb 15, 2018
Copy link
Contributor

left a comment

$ cd LG
$ ./TM

@hub-cap

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2018

@jasontedor you could use readlink too instead of cd

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2018

@hub-cap readlink is different on macOS versus Linux (BSD userspace versus GNU), I do not want another cross-platform branch if we can avoid it.

@hub-cap

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2018

🤦‍♂ makes sense @jasontedor

@jasontedor jasontedor merged commit 1fa701c into elastic:master Feb 16, 2018

3 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
elasticsearch-ci/packaging Build finished.
Details
jasontedor added a commit that referenced this pull request Feb 16, 2018
Fix using relative custom config path
Previously a user could set a custom config path to a relative directory
using ES_PATH_CONF. In a previous change related to enabling GC logging
by default, we forced the working directory for Elasticsearch to be
ES_HOME. This had the impact of causing all relative paths to be
relative to ES_HOME, against the intent of the user. This commit
addresses this by making ES_PATH_CONF absolute before we switch the
working directory to ES_HOME.

Relates #28700
jasontedor added a commit that referenced this pull request Feb 16, 2018
Fix using relative custom config path
Previously a user could set a custom config path to a relative directory
using ES_PATH_CONF. In a previous change related to enabling GC logging
by default, we forced the working directory for Elasticsearch to be
ES_HOME. This had the impact of causing all relative paths to be
relative to ES_HOME, against the intent of the user. This commit
addresses this by making ES_PATH_CONF absolute before we switch the
working directory to ES_HOME.

Relates #28700

@jasontedor jasontedor deleted the jasontedor:fix-relative-es-path-conf branch Feb 16, 2018

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2018

Thanks @rjernst and @talevy.

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.