Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable selecting adaptive selection stats #28721

Merged
merged 5 commits into from Feb 19, 2018

Conversation

jasontedor
Copy link
Member

The node stats API enables filtlering the top-level stats for only desired top-level stats. Yet, this was never enabled for adaptive replica selection stats. This commit enables this. We also add setting these stats on the request builder, and fix an inconsistent name in a setter.

The node stats API enables filtlering the top-level stats for only
desired top-level stats. Yet, this was never enabled for adaptive
replica selection stats. This commit enables this. We also add setting
these stats on the request builder, and fix an inconsistent name in a
setter.
@jasontedor jasontedor added review :Data Management/Stats Statistics tracking and retrieval APIs v7.0.0 v6.3.0 labels Feb 18, 2018
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


`adaptive_selection`::
Statistics about <<search-adaptive-replica,adaptive replica selection>>. See
<<adaptive-selection-stats adaptive selection statistis>>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: statistis -> statistics

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, missing a comma after adaptive-selection-stats?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed c9a7c7a.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jasontedor jasontedor merged commit 105dcb5 into elastic:master Feb 19, 2018
jasontedor added a commit that referenced this pull request Feb 19, 2018
The node stats API enables filtlering the top-level stats for only
desired top-level stats. Yet, this was never enabled for adaptive
replica selection stats. This commit enables this. We also add setting
these stats on the request builder, and fix an inconsistent name in a
setter.

Relates #28721
@jasontedor jasontedor deleted the adaptive-selection-stats branch February 19, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants