New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable selecting adaptive selection stats #28721
Enable selecting adaptive selection stats #28721
Conversation
The node stats API enables filtlering the top-level stats for only desired top-level stats. Yet, this was never enabled for adaptive replica selection stats. This commit enables this. We also add setting these stats on the request builder, and fix an inconsistent name in a setter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
`adaptive_selection`:: | ||
Statistics about <<search-adaptive-replica,adaptive replica selection>>. See | ||
<<adaptive-selection-stats adaptive selection statistis>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: statistis -> statistics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, missing a comma after adaptive-selection-stats
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed c9a7c7a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
The node stats API enables filtlering the top-level stats for only desired top-level stats. Yet, this was never enabled for adaptive replica selection stats. This commit enables this. We also add setting these stats on the request builder, and fix an inconsistent name in a setter. Relates #28721
The node stats API enables filtlering the top-level stats for only desired top-level stats. Yet, this was never enabled for adaptive replica selection stats. This commit enables this. We also add setting these stats on the request builder, and fix an inconsistent name in a setter.