Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit analyzed text for highlighting (improvements) #28808

Conversation

Projects
None yet
4 participants
@mayya-sharipova
Copy link
Contributor

commented Feb 24, 2018

Increase the default limit of index.highlight.max_analyzed_offset to 1M instead of previous 10K.

Enhance an error message when offset increased to include field name, index name and doc_id.

Relates to #27934, elastic/kibana#16764

Limit analyzed text for highlighting (improvements)
Increase the default limit of `index.highlight.max_analyzed_offset` to 1M instead of previous 10K.

Enhance an error message when offset increased to include field name, index name and doc_id.

Relates to elastic/kibana#16764
@jimczi

jimczi approved these changes Feb 28, 2018

Copy link
Member

left a comment

@mayya-sharipova mayya-sharipova merged commit f53d159 into elastic:master Mar 2, 2018

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details

@mayya-sharipova mayya-sharipova deleted the mayya-sharipova:limit-analyzed-text-for-highlight2 branch Mar 2, 2018

martijnvg added a commit that referenced this pull request Mar 8, 2018

Merge remote-tracking branch 'es/master' into ccr
* es/master: (48 commits)
  Update bucket-sort-aggregation.asciidoc (#28937)
  [Docs] REST high-level client: Fix code for most basic search request (#28916)
  Improved percolator's random candidate query duel test and fixed bugs that were exposed by this:
  Revert "Rescore collapsed documents (#28521)"
  Build: Fix test logger NPE when no tests are run (#28929)
  [TEST] AwaitsFix QueryRescorerIT.testRescoreAfterCollapse
  Decouple XContentType from StreamInput/Output (#28927)
  Remove BytesRef usage from XContentParser and its subclasses (#28792)
  [DOCS] Correct typo in configuration (#28903)
  Fix incorrect datemath example (#28904)
  Add a usage example of the JLH score (#28905)
  Wrap stream passed to createParser in try-with-resources (#28897)
  Rescore collapsed documents (#28521)
  Fix (simple)_query_string to ignore removed terms (#28871)
  [Docs] Fix typo in composite aggregation (#28891)
  Try if tombstone is eligable for pruning before locking on it's key (#28767)
  Limit analyzed text for highlighting (improvements) (#28808)
  Missing `timeout` parameter from the REST API spec JSON files (#28328)
  Clarifies how query_string splits textual part (#28798)
  Update outdated java version reference (#28870)
  ...

sebasjm pushed a commit to sebasjm/elasticsearch that referenced this pull request Mar 10, 2018

Limit analyzed text for highlighting (improvements) (elastic#28808)
Increase the default limit of `index.highlight.max_analyzed_offset` to 1M instead of previous 10K.

Enhance an error message when offset increased to include field name, index name and doc_id.

Relates to elastic/kibana#16764

@s1monw s1monw added the >enhancement label Mar 20, 2018

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.