Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject setting index.optimize_auto_generated_id after version 7.0.0 #28895

Merged
merged 8 commits into from Feb 10, 2019

Conversation

Projects
None yet
8 participants
@liketic
Copy link
Contributor

commented Mar 4, 2018

Do not allow modify setting index.optimize_auto_generated_id after version 7.0.

Relates to #27600

@elasticmachine

This comment has been minimized.

Copy link

commented Mar 4, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine

This comment has been minimized.

Copy link

commented Mar 4, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jasontedor
Copy link
Member

left a comment

I left a comment about the location of the test.

import org.elasticsearch.test.IndexSettingsModule;


public class EngineConfigTests extends ESTestCase {

This comment has been minimized.

Copy link
@jasontedor

jasontedor Mar 4, 2018

Member

I do not think we need a new class for this. Maybe there is an existing class where this would be appropriate?

This comment has been minimized.

Copy link
@liketic

liketic Mar 5, 2018

Author Contributor

Thanks @jasontedor , how about elasticsearch/server/src/test/java/org/elasticsearch/index/engine/InternalEngineTests.java or elasticsearch/server/src/test/java/org/elasticsearch/index/engine/InternalEngineSettingsTests.java ?

This comment has been minimized.

Copy link
@jasontedor

jasontedor Mar 8, 2018

Member

That sounds better.

This comment has been minimized.

Copy link
@liketic

liketic Mar 12, 2018

Author Contributor

I moved the test to InternalEngineTests.java. I'm not sure if it's appropriate. Please review again, thanks!

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 24, 2018

@javanna

This comment has been minimized.

Copy link
Member

commented May 7, 2018

Review comment seems to have been addressed, @jasontedor would you mind having another look?

@javanna javanna added the review label May 7, 2018

@jasontedor

This comment has been minimized.

Copy link
Member

commented May 25, 2018

@liketic The change looks good; can you merge master and resolve conflicts and we can integrate this?

@liketic

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2018

Thanks @jasontedor , please review again.

@jasontedor

This comment has been minimized.

Copy link
Member

commented Jun 3, 2018

@elasticmachine test this please

@javanna

This comment has been minimized.

Copy link
Member

commented Aug 16, 2018

@jasontedor does it make sense to try and resurrect this one together with #28862?

@rjernst rjernst removed the review label Oct 10, 2018

@jasontedor

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

@liketic Can you bring this PR up to date with master? I tried to merge master in and didn't merge cleanly.

liketic added some commits Dec 13, 2018

@liketic

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2018

Thanks @jasontedor , please review again.

@jasontedor
Copy link
Member

left a comment

I left a comment. Let me know if you need a pointer to the right place to reject this setting.

@@ -126,6 +127,11 @@ public EngineConfig(ShardId shardId, String allocationId, ThreadPool threadPool,
List<ReferenceManager.RefreshListener> internalRefreshListener, Sort indexSort,
CircuitBreakerService circuitBreakerService, LongSupplier globalCheckpointSupplier,
LongSupplier primaryTermSupplier, TombstoneDocSupplier tombstoneDocSupplier) {
if (indexSettings.getIndexVersionCreated().onOrAfter(Version.V_7_0_0)

This comment has been minimized.

Copy link
@jasontedor

jasontedor Dec 20, 2018

Member

I think this is too late to be rejecting this setting. It means the index will already be created and in the cluster state, but all shards will fail during engine creation. The user will be left with a red index.

This comment has been minimized.

Copy link
@liketic

liketic Dec 23, 2018

Author Contributor

Thanks. I moved to createIndexService. Could you please review again?

liketic added some commits Dec 23, 2018

Merge branch 'master' into pr/28895
* master: (1159 commits)
  Fix timezone fallback in ingest processor (#38407)
  Avoid polluting download stats on builds (#38660)
  SQL: Prevent grouping over grouping functions (#38649)
  SQL: Relax StackOverflow circuit breaker for constants (#38572)
  [DOCS] Fixes broken migration links (#38655)
  Drop support for the low-level REST client on JDK 7 (#38540)
  [DOCS] Adds placeholders for v8 highlights, breaking changes, release notes (#38641)
  fix dissect doc "ip" --> "clientip" (#38545)
  Concurrent file chunk fetching for CCR restore (#38495)
  make DateMathIndexExpressionsIntegrationIT more resilient (#38473)
  SQL: Replace joda with java time (#38437)
  Add fuzziness example (#37194) (#38648)
  Mute AnalysisModuleTests#testStandardFilterBWC (#38636)
  add geotile_grid ref to asciidoc (#38632)
  Enable Dockerfile from artifacts.elastic.co (#38552)
  Mute FollowerFailOverIT testFailOverOnFollower (#38634)
  Account for a possible rolled over file while reading the audit log file (#34909)
  Mute failure in InternalEngineTests (#38622)
  Fix Issue with Concurrent Snapshot Init + Delete (#38518)
  Refactor ZonedDateTime.now in millis resolution (#38577)
  ...
@jasontedor

This comment has been minimized.

Copy link
Member

commented Feb 10, 2019

@elasticmachine test this please

@jasontedor jasontedor merged commit fe5bdb4 into elastic:master Feb 10, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

jasontedor added a commit that referenced this pull request Feb 10, 2019

Reject index.optimize_auto_generated_id setting (#28895)
This commit rejects the index.optmize_auto_generated_id setting for
indices created on or after 7.0.0. This setting was deprecated in 6.7.0.

jasontedor added a commit that referenced this pull request Feb 10, 2019

Reject index.optimize_auto_generated_id setting (#28895)
This commit rejects the index.optmize_auto_generated_id setting for
indices created on or after 7.0.0. This setting was deprecated in 6.7.0.

@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 12, 2019

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Feb 12, 2019

Reject index.optimize_auto_generated_id setting (elastic#28895)
This commit rejects the index.optmize_auto_generated_id setting for
indices created on or after 7.0.0. This setting was deprecated in 6.7.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.