New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop sourcing scripts during installation/removal #28918
Stop sourcing scripts during installation/removal #28918
Conversation
Previously we allowed a lot of customization of Elasticsearch during package installation (e.g., the username and group). This customization was achieved by sourcing the env script (e.g., /etc/sysconfig/elasticsearch) during installation. Since we no longer allow such flexibility, we do not need to source these env scripts during package installation and removal.
FYI @elastic/es-core-infra. |
run packaging tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
run packaging tests |
1 similar comment
run packaging tests |
test this please |
I cancelled the packaging tests job after it had been frozen for ~1hr 20min so the elasticsearch-ci cluster could be unblocked from restarting. Feel free to re-trigger if you'd like to try them again. |
run packaging tests |
@elasticdog No worries, thank you for the heads up. |
run packaging tests |
1 similar comment
run packaging tests |
Previously we allowed a lot of customization of Elasticsearch during package installation (e.g., the username and group). This customization was achieved by sourcing the env script (e.g., /etc/sysconfig/elasticsearch) during installation. Since we no longer allow such flexibility, we do not need to source these env scripts during package installation and removal.
Previously we allowed a lot of customization of Elasticsearch during package installation (e.g., the username and group). This customization was achieved by sourcing the env script (e.g., /etc/sysconfig/elasticsearch) during installation. Since we no longer allow such flexibility, we do not need to source these env scripts during package installation and removal.
Relates #14630