Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sourcing scripts during installation/removal #28918

Merged

Conversation

jasontedor
Copy link
Member

Previously we allowed a lot of customization of Elasticsearch during package installation (e.g., the username and group). This customization was achieved by sourcing the env script (e.g., /etc/sysconfig/elasticsearch) during installation. Since we no longer allow such flexibility, we do not need to source these env scripts during package installation and removal.

Relates #14630

Previously we allowed a lot of customization of Elasticsearch during
package installation (e.g., the username and group). This customization
was achieved by sourcing the env script (e.g.,
/etc/sysconfig/elasticsearch) during installation. Since we no longer
allow such flexibility, we do not need to source these env scripts
during package installation and removal.
@jasontedor jasontedor added review :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v7.0.0 v6.3.0 labels Mar 6, 2018
@jasontedor
Copy link
Member Author

FYI @elastic/es-core-infra.

@jasontedor
Copy link
Member Author

run packaging tests

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasontedor
Copy link
Member Author

run packaging tests

1 similar comment
@jasontedor
Copy link
Member Author

run packaging tests

@jasontedor
Copy link
Member Author

test this please

@jasontedor jasontedor removed the review label Mar 7, 2018
@elasticdog
Copy link
Contributor

I cancelled the packaging tests job after it had been frozen for ~1hr 20min so the elasticsearch-ci cluster could be unblocked from restarting. Feel free to re-trigger if you'd like to try them again.

@jasontedor
Copy link
Member Author

run packaging tests

@jasontedor
Copy link
Member Author

@elasticdog No worries, thank you for the heads up.

@jasontedor
Copy link
Member Author

run packaging tests

1 similar comment
@jasontedor
Copy link
Member Author

run packaging tests

@jasontedor jasontedor merged commit f0164cc into elastic:master Mar 12, 2018
jasontedor added a commit that referenced this pull request Mar 12, 2018
Previously we allowed a lot of customization of Elasticsearch during
package installation (e.g., the username and group). This customization
was achieved by sourcing the env script (e.g.,
/etc/sysconfig/elasticsearch) during installation. Since we no longer
allow such flexibility, we do not need to source these env scripts
during package installation and removal.
@jasontedor jasontedor deleted the remove-package-source-env-script branch March 12, 2018 17:49
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >enhancement Team:Delivery Meta label for Delivery team v6.3.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants