Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not swallow fail to convert exceptions #29043

Merged
merged 2 commits into from Mar 14, 2018

Conversation

Projects
None yet
4 participants
@jasontedor
Copy link
Member

commented Mar 14, 2018

When converting the source for an indexing request to JSON, the conversion can throw an I/O exception which we swallow and proceed with logging to the slow log. The cause of the I/O exception is lost. This commit changes this behavior and chooses to drop the entry from the slow logs and instead lets an exception percolate up to the indexing operation listener loop. Here, the exception will be caught and logged at the warn level.

Closes #19573

Do not swallow fail to convert exceptions
When converting the source for an indexing request to JSON, the
conversion can throw an I/O exception which we swallow and proceed with
logging to the slow log. The cause of the I/O exception is lost. This
commit changes this behavior and chooses to drop the entry from the slow
logs and instead lets an exception percolate up to the indexing
operation listener loop. Here, the exception will be caught and logged
at the warn level.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2018

@rjernst
Copy link
Member

left a comment

LGTM

@jasontedor jasontedor merged commit 647d0a1 into elastic:master Mar 14, 2018

1 of 2 checks passed

elasticsearch-ci Build started sha1 is merged.
Details
CLA Commit author is a member of Elasticsearch
Details

jasontedor added a commit that referenced this pull request Mar 14, 2018

Do not swallow fail to convert exceptions (#29043)
When converting the source for an indexing request to JSON, the
conversion can throw an I/O exception which we swallow and proceed with
logging to the slow log. The cause of the I/O exception is lost. This
commit changes this behavior and chooses to drop the entry from the slow
logs and instead lets an exception percolate up to the indexing
operation listener loop. Here, the exception will be caught and logged
at the warn level.

@jasontedor jasontedor deleted the jasontedor:slow-log-exception-swallowing branch Mar 14, 2018

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2018

Thanks @rjernst.

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.