Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add noop from local translog to translog again #29637

Merged
merged 4 commits into from Apr 26, 2018

Conversation

Projects
None yet
4 participants
@dnhatn
Copy link
Contributor

commented Apr 20, 2018

Today we always add no-ops to translog regardless of its origin, thus a
noop may appear in the translog multiple times. This is not a big deal
as noops are small and rare.

This commit ensures to add a noop to translog only if its origin is not
from local translog. This restriction has been applied for index and
delete.

Do not add noop from local translog to translog again
Today we always add no-ops to translog regardless of its origin, thus a
noop may appear in the translog multiple times. This is not a big deal
as noops are small and rare to appear.

This commit ensures to add a noop to translog only if its origin is not
from local translog. This restriction has been applied for index and
delete.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Apr 20, 2018

@bleskes
Copy link
Member

left a comment

LGTM. Any specific reason to look at this now?

@dnhatn

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2018

Any specific reason to look at this now?

@bleskes I am working to index a tombstone for no-op in the soft-deletes branch as we would like to have a complete sequence history in Lucene.

@dnhatn dnhatn changed the title Do not add Noop from local translog to translog again Do not add noop from local translog to translog again Apr 20, 2018

@dnhatn dnhatn added v6.4.0 and removed v6.3.0 labels Apr 24, 2018

@dnhatn

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2018

Thanks @bleskes

@dnhatn dnhatn merged commit 52c50e3 into elastic:master Apr 26, 2018

3 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@dnhatn dnhatn deleted the dnhatn:not-add-noops branch Apr 26, 2018

dnhatn added a commit that referenced this pull request Apr 26, 2018

Do not add noop from local translog to translog again (#29637)
Today we always add no-ops to translog regardless of its origin, thus a
noop may appear in the translog multiple times. This is not a big deal
as noops are small and rare to appear.

This commit ensures to add a noop to translog only if its origin is not
from local translog. This restriction has been applied for index and
delete.

martijnvg added a commit that referenced this pull request Apr 26, 2018

Merge remote-tracking branch 'es/master' into ccr
* es/master:
  Watcher: Fold two smoke test projects into smoke-test-watcher (#30137)
  In the field capabilities API, deprecate support for providing fields in the request body. (#30157)
  Set JAVA_HOME before forking setup commands (#29647)
  Remove animal sniffer from low-level REST client (#29646)
  Cleanup .gitignore (#30145)
  Do not add noop from local translog to translog again (#29637)
  Build: Assert jar LICENSE and NOTICE files match
  Correct transport compression algorithm in docs (#29645)
  [Test] Fix docs check for DEB package in packaging tests (#30126)
  Painless: Docs Clean Up (#29592)
  Fixes Eclipse build for sql jdbc project (#30114)
  Remove reference to `not_analyzed`.
  [Docs] Add community analysis plugin (#29612)

martijnvg added a commit that referenced this pull request Apr 26, 2018

Merge remote-tracking branch 'es/6.x' into ccr-6.x
* es/6.x:
  In the field capabilities API, deprecate support for providing fields in the request body. (#30157)
  Set JAVA_HOME before forking setup commands (#29647)
  Remove animal sniffer from low-level REST client (#29646)
  Cleanup .gitignore (#30145)
  Do not add noop from local translog to translog again (#29637)
  Painless: Docs Clean Up (#29592)
  Build: Assert jar LICENSE and NOTICE files match
  Correct transport compression algorithm in docs (#29645)
  AwaitsFix for testGradleVersionsMatchVersionUtils
  [Test] Fix docs check for DEB package in packaging tests (#30126)
  Remove reference to `not_analyzed`.
  [Docs] Add community analysis plugin (#29612)
  [DOCS] Removed differencies between text and code (#27993)

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.