Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay _uid field data deprecation warning #30651

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
3 participants
@jimczi
Copy link
Member

commented May 16, 2018

A deprecation warning is printed when creating the fieldddata builder for the _uid field.
This change moves the deprecation logging to the building of the fielddata since otherwise
APIs like _field_caps can emit deprecation warning when they just test the capabilities
of the _uid field.

Closes #30625

Delay _uid field data deprecation warning
A deprecation warning is printed when creating the fieldddata builder for the `_uid` field.
This change moves the deprecation logging to the building of the fielddata since otherwise
APIs like `_field_caps` can emit deprecation warning when they just test the capabilities
of the `_uid` field.

Closes #30625
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2018

Pinging @elastic/es-search-aggs

@jimczi jimczi merged commit b2c88df into elastic:6.x May 16, 2018

3 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@jimczi jimczi deleted the jimczi:uid_deprecation branch May 16, 2018

jimczi added a commit that referenced this pull request May 16, 2018

Delay _uid field data deprecation warning (#30651)
A deprecation warning is printed when creating the fieldddata builder for the `_uid` field.
This change moves the deprecation logging to the building of the fielddata since otherwise
APIs like `_field_caps` can emit deprecation warning when they just test the capabilities
of the `_uid` field.

Closes #30625

martijnvg added a commit that referenced this pull request May 17, 2018

Merge remote-tracking branch 'es/6.x' into ccr-6.x
* es/6.x: (44 commits)
  SQL: Remove dependency for server's version from JDBC driver (#30631)
  Make xpack modules instead of a meta plugin (#30589)
  Security: Remove SecurityLifecycleService (#30526)
  Build: Add task interdependencies for ssl configuration (#30633)
  Mute ShrinkIndexIT
  [ML] DeleteExpiredDataAction should use client with origin (#30646)
  Reindex: Fixed typo in assertion failure message (#30619)
  [DOCS] Fixes list of unconverted snippets in build.gradle
  Use readFully() to read bytes from CipherInputStream (#30640)
  Add Create Repository High Level REST API (#30501)
  [DOCS] Reorganizes RBAC documentation
  Test: increase search logging for LicensingTests
  Delay _uid field data deprecation warning (#30651)
  Deprecate Empty Templates (#30194)
  Remove unused DirectoryUtils class. (#30582)
  Mitigate date histogram slowdowns with non-fixed timezones. (#30534)
  [TEST] Remove AwaitsFix in IndicesOptionsTests#testSerialization
  S3 repo plugin populates SettingsFilter (#30652)
  Rest High Level client: Add List Tasks (#29546)
  Fixes IndiceOptionsTests to serialise correctly (#30644)
  ...

@jpountz jpountz added v6.3.0 and removed v6.3.1 labels Jun 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.