Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGGING: Upgrade to Log4J 2.11.1 #32616

Merged
merged 7 commits into from Aug 6, 2018

Conversation

@original-brownbear
Copy link
Member

commented Aug 3, 2018

LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes #32537
* Fixes #27300
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2018

@original-brownbear

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2018

looks like the third party audit fails on CI (passed locally) ... will fix in a few hours

@jasontedor
Copy link
Member

left a comment

Great find. LGTM assuming that you get a green PR CI build and have third-party audit passing on JDK 8, JDK 10, and JDK 11. I think that we should backport this to 5.6.11 too.

@jasontedor jasontedor added the v5.6.11 label Aug 3, 2018

@jasontedor

This comment has been minimized.

Copy link
Member

commented Aug 3, 2018

In fact, I would support merging this to 6.4.0.

@jasontedor jasontedor added the v6.4.0 label Aug 3, 2018

@original-brownbear

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2018

@jasontedor alrighty got it green :)
Just one trivial change to the tests (that nicely shows that this should fix the problem I think) https://github.com/elastic/elasticsearch/pull/32616/files#diff-d0333c88811865623eb43c70c4e1c14bR49

and conditional excludes to make JDK8 auditing pass.

Can you take another look please? :)

@jasontedor
Copy link
Member

left a comment

LGTM.

@original-brownbear

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2018

@jasontedor thanks! Merging + back porting then :)

@original-brownbear original-brownbear merged commit 0a67cb4 into elastic:master Aug 6, 2018

3 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@original-brownbear original-brownbear deleted the original-brownbear:32537 branch Aug 6, 2018

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 6, 2018
LOGGING: Upgrade to Log4J 2.11.1 (elastic#32616)
* LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes elastic#32537
* Fixes elastic#27300
original-brownbear added a commit that referenced this pull request Aug 7, 2018
LOGGING: Upgrade to Log4J 2.11.1 (#32616) (#32656)
* LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes #32537
* Fixes #27300
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 7, 2018
LOGGING: Upgrade to Log4J 2.11.1 (elastic#32616)
* LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes elastic#32537
* Fixes elastic#27300
original-brownbear added a commit that referenced this pull request Aug 7, 2018
LOGGING: Upgrade to Log4J 2.11.1 (#32616) (#32668)
* LOGGING: Upgrade to Log4J 2.11.1
* Upgrade to `2.11.1` to fix memory leaks in slow logger when logging large requests
   * This was caused by a bug in Log4J https://issues.apache.org/jira/browse/LOG4J2-2269 and is fixed in `2.11.1` via https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;h=9496c0c
* Fixes #32537
* Fixes #27300

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.