Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Painless] Allow statically imported methods without whitelisted class #34370

Merged
merged 1 commit into from Oct 10, 2018

Conversation

@jdconrad
Copy link
Contributor

commented Oct 9, 2018

Currently, a class must be whitelisted separately to allow a statically imported method to also be whitelisted. This removes the extraneous check to see if the class for a statically imported method is already whitelisted, so a statically imported method can be whitelisted independently.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2018

@rjernst
rjernst approved these changes Oct 9, 2018
Copy link
Member

left a comment

Lgtm

@jdconrad

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2018

@rjernst Thanks for the review! Will commit as soon as CI passes.

@jdconrad jdconrad merged commit 4270085 into elastic:master Oct 10, 2018

4 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details
jdconrad added a commit that referenced this pull request Oct 10, 2018
[Painless] Allow statically imported methods without whitelist class. (
…#34370)

This removes the extraneous check to see if the class for a statically imported 
method is already whitelisted, so a statically imported method can be whitelisted
independently.
@jdconrad jdconrad referenced this pull request Oct 16, 2018
3 of 23 tasks complete
kcm added a commit that referenced this pull request Oct 30, 2018
[Painless] Allow statically imported methods without whitelist class. (
…#34370)

This removes the extraneous check to see if the class for a statically imported 
method is already whitelisted, so a statically imported method can be whitelisted
independently.

@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.