New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SSLDriver for JDK 11 changes #34398

Open
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tbrooks8
Contributor

tbrooks8 commented Oct 11, 2018

JDK11 introduced some changes with the SSLEngine. A number of error
messages were changed. Additionally, there were some behavior changes
in regard to how the SSLEngine handles closes during the handshake
process. This commit updates our tests and SSLDriver to support these
changes.

tbrooks8 added some commits Sep 25, 2018

WIP
WIP
WIP
WIP
@elasticmachine

This comment has been minimized.

Show comment
Hide comment
@elasticmachine

elasticmachine commented Oct 11, 2018

@jaymode jaymode self-requested a review Oct 11, 2018

@jaymode

LGTM. I left some minor suggestions but your call on whether to take them or leave them

}
@Override
public void read(InboundChannelBuffer buffer) throws SSLException {
if (needToReceiveClose == false) {
// There is an issue where receiving handshake messages after initiating the close process

This comment has been minimized.

@jaymode

jaymode Oct 11, 2018

Member

is there an OpenJDK issue about this insanity?

@jaymode

jaymode Oct 11, 2018

Member

is there an OpenJDK issue about this insanity?

Show outdated Hide outdated .../main/java/org/elasticsearch/xpack/security/transport/nio/SSLDriver.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment